make ConvertedOP normalized again

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "ClassicalOrthogonalPolynomials"
 uuid = "b30e2e7b-c4ee-47da-9d5f-2c5c27239acd"
 authors = ["Sheehan Olver <[email protected]>"]
-version = "0.14.3"
+version = "0.15"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/choleskyQR.jl

@@ -1,5 +1,5 @@
 """
-Represent an Orthogonal polynomial which has a conversion operator from P, that is, Q = P * inv(U).
+Represents orthonormal polynomials defined via a conversion operator from P, that is, Q = P * inv(U).
 """
 struct ConvertedOrthogonalPolynomial{T, WW<:AbstractQuasiVector{T}, XX, UU, PP} <: OrthonormalPolynomial{T}
     weight::WW
@@ -13,11 +13,8 @@ _p0(Q::ConvertedOrthogonalPolynomial) = _p0(Q.P)/Q.U[1,1]
 axes(Q::ConvertedOrthogonalPolynomial) = axes(Q.P)
 
 
-struct ConvertedOPLayout <: AbstractOPLayout end
+struct ConvertedOPLayout <: AbstractNormalizedOPLayout end
 MemoryLayout(::Type{<:ConvertedOrthogonalPolynomial}) = ConvertedOPLayout()
-equals_layout(::ConvertedOPLayout, ::ConvertedOPLayout, P, Q) = orthogonalityweight(P) == orthogonalityweight(Q)
-equals_layout(::ConvertedOPLayout, ::AbstractOPLayout, P, Q) = false # fix
-equals_layout(::AbstractOPLayout, ::ConvertedOPLayout, P, Q) = false # fix
 
 
 

test/test_choleskyQR.jl

@@ -230,7 +230,6 @@ import LazyArrays: AbstractCachedMatrix, resizedata!
 
         @test Q[0.1,1] ≈ 1/sqrt(2)
         @test Q[0.1,1:10] ≈ Q̃[0.1,1:10]
-        # AWESOME, thanks TSGUT!!
         @test Q[0.1,10_000] ≈ Q̃[0.1,10_000]
 
         R = P \ Q