Skip to content

Commit 0c44156

Browse files
committed
add tests and use expand
1 parent 8594a4e commit 0c44156

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

Project.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
88
BandedMatrices = "aae01518-5342-5314-be14-df237901396f"
99
BlockArrays = "8e7c35d0-a365-5155-bbbb-fb81a777f24e"
1010
DomainSets = "5b8099bc-c8ec-5219-889f-1d9e522a28bf"
11+
FastTransforms = "057dd010-8810-581a-b7be-e3fc3b93f78c"
1112
FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
1213
InfiniteArrays = "4858937d-0d70-526a-a4dd-2d5cb5dd786c"
1314
Infinities = "e1ba4f0e-776d-440f-acd9-e1d2e9742647"

src/bases/bases.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ copy(L::Ldiv{<:AbstractBasisLayout,<:AbstractWeightLayout}) = transform_ldiv(L.A
122122
@inline function _broadcast_mul_ldiv(::Tuple{Any,AbstractBasisLayout}, A, B)
123123
a,b = arguments(B)
124124
@assert a isa AbstractQuasiVector # Only works for vec .* mat
125-
ab = (A * (A \ a)) .* b # broadcasted should be overloaded
125+
ab = expand(a) .* b # broadcasted should be overloaded
126126
MemoryLayout(ab) isa BroadcastLayout && return transform_ldiv(A, ab)
127127
A \ ab
128128
end
@@ -158,7 +158,7 @@ copy(L::Ldiv{<:MappedBasisLayouts,BroadcastLayout{typeof(*)}}) = _broadcast_mul_
158158
a,b = arguments(B)
159159
@assert a isa AbstractQuasiVector # Only works for vec .* mat
160160
A = Ac'
161-
ab = (A * (A \ a)) .* b # broadcasted should be overloaded
161+
ab = expand(a) .* b # broadcasted should be overloaded
162162
MemoryLayout(ab) isa BroadcastLayout && return Ac*transform_ldiv(A, ab)
163163
Ac*ab
164164
end

test/Project.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[deps]

test/test_chebyshev.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
using ContinuumArrays, LinearAlgebra, FastTransforms, QuasiArrays, ArrayLayouts, Base64, LazyArrays, Test
1+
using ContinuumArrays, LinearAlgebra, QuasiArrays, ArrayLayouts, Base64, LazyArrays, Test
2+
using FastTransforms
23
import ContinuumArrays: Basis, Weight, Map, LazyQuasiArrayStyle, TransformFactorization,
34
ExpansionLayout, checkpoints, MappedBasisLayout, MappedWeightedBasisLayout,
45
SubWeightedBasisLayout, WeightedBasisLayout, WeightLayout, basis, grammatrix
@@ -159,6 +160,8 @@ Base.:(==)(::FooBasis, ::FooBasis) = true
159160

160161
= T * (T \ a)
161162
@test T \ (ã .* ã) [1.5,1,0.5,0,0]
163+
164+
@test T'*(a .* T) isa Matrix
162165
end
163166

164167
@testset "sum/dot/diff" begin

0 commit comments

Comments
 (0)