some more fixes

Author: dlfivefifty

src/FastTransforms.jl

@@ -21,10 +21,11 @@ else
     const LAmul! = LinearAlgebra.mul!
     const libfftw = libfftw3
     const libfftwf = libfftw3f
-    import LinearAlgebra: Factorization, transpose, adjoint
+    import LinearAlgebra: Factorization
     flipdim(A,d) = reverse(A; dims=d)
 end
 
+
 import Base: *, \, size, view
 import Base: getindex, setindex!, length
 import Compat.LinearAlgebra: BlasFloat, BlasInt
@@ -33,7 +34,7 @@ import HierarchicalMatrices: mul!, At_mul_B!, Ac_mul_B!
 import HierarchicalMatrices: ThreadSafeVector, threadsafezeros
 import LowRankApprox: ColPerm
 import AbstractFFTs: Plan
-import Compat: range
+import Compat: range, transpose, adjoint
 
 export cjt, icjt, jjt, plan_cjt, plan_icjt
 export leg2cheb, cheb2leg, leg2chebu, ultra2ultra, jac2jac

src/SphericalHarmonics/synthesisanalysis.jl

@@ -230,7 +230,7 @@ end
 
 function row_synthesis!(P, C, cfs::Vector{T}) where T
     n = length(cfs)
-    lmul!(C, reverseeven!(negateeven!(cfs)))
+    lmul!(C', reverseeven!(negateeven!(cfs)))
     if iseven(n)
         cfs[n÷2+1] *= two(T)
     end

test/sphericalharmonics/synthesisanalysistests.jl

@@ -3,6 +3,10 @@ using Compat.Test
 
 import FastTransforms: normalizecolumns!, maxcolnorm
 
+if VERSION ≥ v"0.7-"
+    vecnorm(A, p...) = norm(A, p...)
+end
+
 @testset "Synthesis and analysis" begin
 
     # Starting with normalized spherical harmonic coefficients,

test/sphericalharmonics/vectorfieldtests.jl

@@ -14,24 +14,24 @@ using Compat.Test
     V1 = zero(∇θF)
     V2 = zero(∇φF)
     Pa = FastTransforms.plan_analysis(∇θF)
-    A_mul_B!(V1, V2, Pa, ∇θF, ∇φF)
+    mul!(V1, V2, Pa, ∇θF, ∇φF)
     P = SlowSphericalHarmonicPlan(V1)
 
     U1 = zero(V1)
     U2 = zero(V2)
-    At_mul_B!(U1, U2, P, V1, V2)
+    FastTransforms.At_mul_B!(U1, U2, P, V1, V2)
 
     W1 = zero(U1)
     W2 = zero(U2)
 
-    A_mul_B!(W1, W2, P, U1, U2)
+    mul!(W1, W2, P, U1, U2)
 
     Ps = FastTransforms.plan_synthesis(W1)
 
     G1 = zero(∇θF)
     G2 = zero(∇φF)
 
-    A_mul_B!(G1, G2, Ps, W1, W2)
+    mul!(G1, G2, Ps, W1, W2)
 
     @test vecnorm(∇θF - G1)/vecnorm(∇θF) < n*eps()
     @test vecnorm(∇φF - G2)/vecnorm(∇φF) < n*eps()
@@ -49,24 +49,24 @@ using Compat.Test
         V1 = zero(∇θF)
         V2 = zero(∇φF)
         Pa = FastTransforms.plan_analysis(∇θF)
-        A_mul_B!(V1, V2, Pa, ∇θF, ∇φF)
+        mul!(V1, V2, Pa, ∇θF, ∇φF)
         P = SlowSphericalHarmonicPlan(V1)
 
         U1 = zero(V1)
         U2 = zero(V2)
-        At_mul_B!(U1, U2, P, V1, V2)
+        FastTransforms.At_mul_B!(U1, U2, P, V1, V2)
 
         W1 = zero(U1)
         W2 = zero(U2)
 
-        A_mul_B!(W1, W2, P, U1, U2)
+        mul!(W1, W2, P, U1, U2)
 
         Ps = FastTransforms.plan_synthesis(W1)
 
         G1 = zero(∇θF)
         G2 = zero(∇φF)
 
-        A_mul_B!(G1, G2, Ps, W1, W2)
+        mul!(G1, G2, Ps, W1, W2)
 
         @test vecnorm(∇θF - G1)/vecnorm(∇θF) < n*eps()
         @test vecnorm(∇φF - G2)/vecnorm(∇φF) < n*eps()