Skip to content

Commit 8ea2da1

Browse files
fix #110 (#111)
* fix 0 dim show * add tests * Update ci.yml * Update ci.yml * coverage --------- Co-authored-by: Sheehan Olver <[email protected]>
1 parent e669bd4 commit 8ea2da1

File tree

3 files changed

+28
-17
lines changed

3 files changed

+28
-17
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,21 @@ jobs:
1010
fail-fast: false
1111
matrix:
1212
version:
13-
- '1.6'
13+
- 'lts'
1414
- '1'
15-
- '^1.11.0-0'
1615
os:
1716
- ubuntu-latest
1817
- macOS-latest
1918
- windows-latest
2019
arch:
2120
- x64
2221
steps:
23-
- uses: actions/checkout@v2
24-
- uses: julia-actions/setup-julia@v1
22+
- uses: actions/checkout@v4
23+
- uses: julia-actions/setup-julia@v2
2524
with:
2625
version: ${{ matrix.version }}
2726
arch: ${{ matrix.arch }}
28-
- uses: actions/cache@v1
27+
- uses: actions/cache@v4
2928
env:
3029
cache-name: cache-artifacts
3130
with:
@@ -38,6 +37,7 @@ jobs:
3837
- uses: julia-actions/julia-buildpkg@v1
3938
- uses: julia-actions/julia-runtest@v1
4039
- uses: julia-actions/julia-processcoverage@v1
41-
- uses: codecov/codecov-action@v1
40+
- uses: codecov/codecov-action@v4
4241
with:
42+
token: ${{ secrets.CODECOV_TOKEN }}
4343
file: lcov.info

src/quasifill.jl

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -198,28 +198,31 @@ show(io::IO, F::AbstractQuasiFill) = summary(io, F)
198198

199199
function summary(io::IO, F::QuasiOnes)
200200
print(io, "ones(")
201-
summary(io, F.axes[1])
202-
for a in tail(F.axes)
203-
print(io, ", ")
204-
summary(io, a)
201+
if !isempty(F.axes)
202+
summary(io, F.axes[1])
203+
for a in tail(F.axes)
204+
print(io, ", ")
205+
summary(io, a)
206+
end
205207
end
206208
print(io, ")")
207209
end
208210

209211
function summary(io::IO, F::QuasiZeros)
210212
print(io, "zeros(")
211-
summary(io, F.axes[1])
212-
for a in tail(F.axes)
213-
print(io, ", ")
214-
summary(io, a)
213+
if !isempty(F.axes)
214+
summary(io, F.axes[1])
215+
for a in tail(F.axes)
216+
print(io, ", ")
217+
summary(io, a)
218+
end
215219
end
216220
print(io, ")")
217221
end
218222

219223
function summary(io::IO, F::QuasiFill)
220-
print(io, "fill($(F.value), ")
221-
summary(io, F.axes[1])
222-
for a in tail(F.axes)
224+
print(io, "fill($(F.value)")
225+
for a in F.axes
223226
print(io, ", ")
224227
summary(io, a)
225228
end

test/test_quasifill.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -706,9 +706,17 @@ import QuasiArrays: AbstractQuasiFill
706706
end
707707

708708
@testset "show" begin
709+
@test stringmime("text/plain",ones(Inclusion([1,2,3]), Inclusion([1,2,4]))) == "ones(Inclusion([1, 2, 3]), Inclusion([1, 2, 4]))"
710+
@test stringmime("text/plain",zeros(Inclusion([1,2,3]), Inclusion([1,2,4]))) == "zeros(Inclusion([1, 2, 3]), Inclusion([1, 2, 4]))"
711+
@test stringmime("text/plain",fill(2,Inclusion([1,2,3]), Inclusion([1,2,4]))) == "fill(2, Inclusion([1, 2, 3]), Inclusion([1, 2, 4]))"
712+
709713
@test stringmime("text/plain",ones(Inclusion([1,2,3]))) == "ones(Inclusion([1, 2, 3]))"
710714
@test stringmime("text/plain",zeros(Inclusion([1,2,3]))) == "zeros(Inclusion([1, 2, 3]))"
711715
@test stringmime("text/plain",fill(2,Inclusion([1,2,3]))) == "fill(2, Inclusion([1, 2, 3]))"
716+
717+
@test stringmime("text/plain",QuasiOnes()) == "ones()"
718+
@test stringmime("text/plain",QuasiZeros()) == "zeros()"
719+
@test stringmime("text/plain",QuasiFill(2)) == "fill(2)"
712720
end
713721

714722
@testset "Mul" begin

0 commit comments

Comments
 (0)