Skip to content

Commit bb710d5

Browse files
authored
cumsum default dims=1 (#103)
* cumsum default dims=1 * Update Project.toml
1 parent 1f44868 commit bb710d5

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "QuasiArrays"
22
uuid = "c4ea9172-b204-11e9-377d-29865faadc5c"
33
authors = ["Sheehan Olver <[email protected]>"]
4-
version = "0.11.4"
4+
version = "0.11.5"
55

66
[deps]
77
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
@@ -21,7 +21,7 @@ QuasiArraysSparseArraysExt = "SparseArrays"
2121

2222
[compat]
2323
ArrayLayouts = "1"
24-
DomainSets = "0.6, 0.7"
24+
DomainSets = "0.7.6"
2525
FillArrays = "1"
2626
LazyArrays = "1.2"
2727
StaticArrays = "1"

src/calculus.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ _sum(V::AbstractQuasiArray, dims) = sum_layout(MemoryLayout(V), V, dims)
77
_sum(V::AbstractQuasiArray, ::Colon) = sum_layout(MemoryLayout(V), V, :)
88

99
_cumsum(A, dims) = cumsum_layout(MemoryLayout(A), A, dims)
10-
cumsum(A::AbstractQuasiArray; dims::Integer) = _cumsum(A, dims)
11-
cumsum(x::AbstractQuasiVector) = cumsum(x, dims=1)
10+
cumsum(A::AbstractQuasiArray; dims::Integer=1) = _cumsum(A, dims)
1211

1312
# sum is equivalent to hitting by ones(n) on the left or right
1413

test/test_calculus.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ using QuasiArrays, IntervalSets, Test
1919
@test sum(ApplyQuasiArray(*, A, B); dims=2) sum(A*B; dims=2)
2020

2121
@test sum(b) last(cumsum(b)) cumsum(b)[2]
22-
@test cumsum(B; dims=1)[2:2,:] sum(B; dims=1)
22+
@test cumsum(B)[2:2,:] cumsum(B; dims=1)[2:2,:] sum(B; dims=1)
2323
@test cumsum(B; dims=2)[:,0.5:0.5] sum(B; dims=2)
2424

2525
@test cumsum(ApplyQuasiArray(*, A, b)) cumsum(A*b)

0 commit comments

Comments
 (0)