Skip to content

Conversation

@DanielVandH
Copy link
Member

@DanielVandH DanielVandH commented Nov 9, 2024

In the formula

$$\dfrac{\mathrm d}{\mathrm dx}\left[(1 - x)\boldsymbol P^{t, (a, 1, c)}\right] = \boldsymbol P^{t, (a+1, 0, c+1)}\boldsymbol R_{(a+1,1,c+1)}^{t,(a+1,0,c+1)}\boldsymbol D_{(a,0,c)}^{t,(a+1,1,c+1)}\boldsymbol L_{\mathrm b, (a, 1, c)}^{t, (a, 0, c)}$$

defining $\boldsymbol D_{(a, -1, c)}^{t, (a+1,0,c+1)}$ that I gave in #111, I was computing the triple matrix product using the bidiagonal conjugation stuff from InfiniteLinearAlgebra.jl. But it's just $\boldsymbol D_{\mathrm b, (a, 1, c)}^{t, (a+1,0,c+1)}$, so I switch over to reusing the existing half-weighted derivatives.

@DanielVandH
Copy link
Member Author

The tests are still only on 1.10. Maybe it needs to be updated to something like

- 'lts'
- '1'
- 'pre'

or just '1' to test on the latest (i.e. 1.11 currently)?

@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (ddebef5) to head (6178298).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   94.48%   94.92%   +0.43%     
==========================================
  Files           3        3              
  Lines         653      650       -3     
==========================================
  Hits          617      617              
+ Misses         36       33       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty merged commit 28b78cb into master Nov 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants