Change formula for weighted conversion #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 94.92% 94.97% +0.05%
==========================================
Files 3 3
Lines 650 657 +7
==========================================
+ Hits 617 624 +7
Misses 33 33 ☔ View full report in Codecov by Sentry. |
dlfivefifty
requested changes
Nov 10, 2024
dlfivefifty
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of computing the transform for the weighted conversion introduced in #118, it turns out that the formula for the coefficients isn't actually too bad. In particular,
where I use the notation$P_1^{t, (a, b, c)} = \beta^{t,(a,b,c)}(x-\alpha^{t,(a,b,c)})$ with
and$\mathrm B(x, y)$ is the beta function. The coefficients are then