Merge pull request #358 from oscardssmith/fix-and-test-undefmatrix

fix and test undef matrix for MArray

Author: ChrisRackauckas

.github/workflows/Downstream.yml

@@ -22,11 +22,11 @@ jobs:
           - {user: SciML, repo: DiffEqBase.jl, group: Core}
           - {user: SciML, repo: DiffEqBase.jl, group: Downstream}
           - {user: SciML, repo: DiffEqBase.jl, group: Downstream2}
-          - {user: SciML, repo: DiffEqSensitivity.jl, group: Core1}
-          - {user: SciML, repo: DiffEqSensitivity.jl, group: Core2}
-          - {user: SciML, repo: DiffEqSensitivity.jl, group: Core3}
-          - {user: SciML, repo: DiffEqSensitivity.jl, group: Core4}
-          - {user: SciML, repo: DiffEqSensitivity.jl, group: Core5}
+          - {user: SciML, repo: SciMLSensitivity.jl, group: Core1}
+          - {user: SciML, repo: SciMLSensitivity.jl, group: Core2}
+          - {user: SciML, repo: SciMLSensitivity.jl, group: Core3}
+          - {user: SciML, repo: SciMLSensitivity.jl, group: Core4}
+          - {user: SciML, repo: SciMLSensitivity.jl, group: Core5}
           - {user: SciML, repo: OrdinaryDiffEq.jl, group: Core}
           - {user: SciML, repo: OrdinaryDiffEq.jl, group: Interface}
           - {user: SciML, repo: DelayDiffEq.jl, group: Interface}

lib/ArrayInterfaceStaticArraysCore/src/ArrayInterfaceStaticArraysCore.jl

@@ -4,7 +4,7 @@ import StaticArraysCore, ArrayInterfaceCore, Adapt
 using LinearAlgebra
 
 function ArrayInterfaceCore.undefmatrix(::StaticArraysCore.MArray{S, T, N, L}) where {S, T, N, L}
-    return MMatrix{L, L, T, L*L}(undef)
+    return StaticArraysCore.MMatrix{L, L, T, L*L}(undef)
 end
 # SArray doesn't have an undef constructor and is going to be small enough that this is fine.
 function ArrayInterfaceCore.undefmatrix(s::StaticArraysCore.SArray)

lib/ArrayInterfaceStaticArraysCore/test/runtests.jl

@@ -1,5 +1,6 @@
 using StaticArrays, ArrayInterfaceCore, ArrayInterfaceStaticArraysCore, Test
 using LinearAlgebra
+using ArrayInterfaceCore: undefmatrix, zeromatrix
 
 x = @SVector [1,2,3]
 @test ArrayInterfaceCore.ismutable(x) == false
@@ -26,4 +27,19 @@ z = rand(4)
 zr = ArrayInterfaceCore.restructure(x, z)
 @test zr isa SMatrix{2, 2}
 @test Base.size(zr) == (2,2)
-@test vec(zr) == vec(z)
+@test vec(zr) == vec(z)
+
+
+@testset "zeromatrix and unsafematrix" begin
+    for T in (Int, Float32, Float64)
+        for (vectype, mattype) in ((SVector{4,T},     SMatrix{4,4,T,16}),
+                                   (MVector{4,T},     MMatrix{4,4,T,16}),
+                                   (SMatrix{2,2,T,4}, SMatrix{4,4,T,16}),
+                                   (MMatrix{2,2,T,4}, MMatrix{4,4,T,16}))
+            v = vectype(rand(T, 4))
+            um = undefmatrix(v)
+            @test typeof(um) == mattype
+            @test zeromatrix(v) == zeros(T,length(v),length(v))
+        end
+    end
+end