Use Base.length rather than dynamic(length(...))

Author: nchisholm

src/ArrayInterface.jl

@@ -54,7 +54,9 @@ static(12)
 """
 @inline length(a::UnitRange{T}) where {T} = last(a) - first(a) + oneunit(T)
 @inline length(x) = Static.maybe_static(known_length, Base.length, x)
-const static_length = length  # for backward compatibility
+
+# Alias to to-be-depreciated internal function
+const static_length = length
 
 @inline static_first(x) = Static.maybe_static(known_first, first, x)
 @inline static_last(x) = Static.maybe_static(known_last, last, x)

src/indexing.jl

@@ -243,7 +243,7 @@ indices calling [`to_axis`](@ref).
 @inline function to_axes(A, inds::Tuple)
     if ndims(A) === 1
         return (to_axis(axes(A, 1), first(inds)),)
-    elseif dynamic(length(inds)) === 1
+    elseif Base.length(inds) === 1
         return (to_axis(eachindex(IndexLinear(), A), first(inds)),)
     else
         return to_axes(A, axes(A), inds)
@@ -378,14 +378,14 @@ end
 _ints2range(x::Integer) = x:x
 _ints2range(x::AbstractRange) = x
 @inline function unsafe_get_collection(A::CartesianIndices{N}, inds) where {N}
-    if (dynamic(length(inds)) === 1 && N > 1) || stride_preserving_index(typeof(inds)) === False()
+    if (Base.length(inds) === 1 && N > 1) || stride_preserving_index(typeof(inds)) === False()
         return Base._getindex(IndexStyle(A), A, inds...)
     else
         return CartesianIndices(to_axes(A, _ints2range.(inds)))
     end
 end
 @inline function unsafe_get_collection(A::LinearIndices{N}, inds) where {N}
-    if dynamic(length(inds)) === 1 && isone(_ndims_index(typeof(inds), static(1)))
+    if Base.length(inds) === 1 && isone(_ndims_index(typeof(inds), static(1)))
         return @inbounds(eachindex(A)[first(inds)])
     elseif stride_preserving_index(typeof(inds)) === True()
         return LinearIndices(to_axes(A, _ints2range.(inds)))