Import group for methods managing immutables

Author: Tokazama

ArrayInterfaceCore/src/ArrayInterfaceCore.jl

@@ -162,30 +162,6 @@ Converts an array of structs formulation to a struct of array.
 """
 aos_to_soa(x) = x
 
-"""
-    fast_scalar_indexing(::Type{T}) -> Bool
-
-Query whether an array type has fast scalar indexing.
-"""
-fast_scalar_indexing(x) = fast_scalar_indexing(typeof(x))
-fast_scalar_indexing(::Type) = true
-fast_scalar_indexing(::Type{<:LinearAlgebra.AbstractQ}) = false
-fast_scalar_indexing(::Type{<:LinearAlgebra.LQPackedQ}) = false
-
-"""
-    allowed_getindex(x,i...)
-
-A scalar `getindex` which is always allowed.
-"""
-allowed_getindex(x, i...) = x[i...]
-
-"""
-    allowed_setindex!(x,v,i...)
-
-A scalar `setindex!` which is always allowed.
-"""
-allowed_setindex!(x, v, i...) = Base.setindex!(x, v, i...)
-
 """
     isstructured(::Type{T}) -> Bool
 

ArrayInterfaceCore/src/indexing.jl

@@ -1,4 +1,29 @@
 
+"""
+    fast_scalar_indexing(::Type{T}) -> Bool
+
+Query whether an array type has fast scalar indexing.
+"""
+fast_scalar_indexing(x) = fast_scalar_indexing(typeof(x))
+fast_scalar_indexing(::Type) = true
+fast_scalar_indexing(::Type{<:LinearAlgebra.AbstractQ}) = false
+fast_scalar_indexing(::Type{<:LinearAlgebra.LQPackedQ}) = false
+
+"""
+    allowed_getindex(x,i...)
+
+A scalar `getindex` which is always allowed.
+"""
+allowed_getindex(x, i...) = x[i...]
+
+"""
+    allowed_setindex!(x,v,i...)
+
+A scalar `setindex!` which is always allowed.
+"""
+allowed_setindex!(x, v, i...) = Base.setindex!(x, v, i...)
+
+
 @inline function _to_cartesian(a, i::CanonicalInt)
     @inbounds(CartesianIndices(ntuple(dim -> indices(a, dim), Val(ndims(a))))[i])
 end

src/ArrayInterface.jl

@@ -1,11 +1,10 @@
 module ArrayInterface
 
 using ArrayInterfaceCore
-import ArrayInterfaceCore: allowed_getindex, allowed_setindex!, aos_to_soa, buffer, can_change_size, can_setindex,
-    deleteat, fast_matrix_colors, fast_scalar_indexing, findstructralnz, has_parent,
-    has_sparsestruct, is_column_major, issingular, is_splat_index, is_lazy_conjugate, insert,
-    isstructured,  matrix_colors, ismutable, restructure, lu_instance,  parent_type, safevec,
-    unsafe_reconstruct, zeromatrix
+import ArrayInterfaceCore: allowed_getindex, allowed_setindex!, aos_to_soa, buffer,
+    has_parent, parent_type, fast_matrix_colors,  findstructralnz, has_sparsestruct,
+    issingular, is_lazy_conjugate,  isstructured,  matrix_colors, restructure, lu_instance,
+    safevec, unsafe_reconstruct, zeromatrix
 
 # ArrayIndex subtypes and methods
 import ArrayInterfaceCore: ArrayIndex, MatrixIndex, VectorIndex, BidiagonalIndex, TridiagonalIndex, StrideIndex
@@ -17,14 +16,18 @@ import ArrayInterfaceCore: OptionallyStaticStepRange, OptionallyStaticUnitRange,
 # dimension methods
 import ArrayInterfaceCore: dimnames, known_dimnames, has_dimnames, from_parent_dims, to_dims, to_parent_dims
 # indexing methods
-import ArrayInterfaceCore: to_axes, to_axis, to_indices, to_index, getindex, setindex!, ndims_index
+import ArrayInterfaceCore: to_axes, to_axis, to_indices, to_index, getindex, setindex!,
+    ndims_index, is_splat_index, fast_scalar_indexing
 # stride layout methods
 import ArrayInterfaceCore: strides, stride_rank, contiguous_axis_indicator, contiguous_batch_size,
-    known_strides, known_offsets,offsets, offset1, known_offset1, contiguous_axis, dense_dims, defines_strides
+    known_strides, known_offsets,offsets, offset1, known_offset1, contiguous_axis, dense_dims,
+    defines_strides, is_column_major
 # axes types and methods
 import ArrayInterfaceCore: axes, axes_types, lazy_axes, LazyAxis
 # static sizing
 import ArrayInterfaceCore: size, known_size, known_length, static_length
+# managing immutables
+import ArrayInterfaceCore: ismutable, can_change_size, can_setindex, deleteat, insert
 
 using LinearAlgebra
 using Requires