Fix dim tests and remove old promote_shape

Author: Tokazama

src/dimensions.jl

@@ -3,20 +3,6 @@ function throw_dim_error(@nospecialize(x), @nospecialize(dim))
     throw(DimensionMismatch("$x does not have dimension corresponding to $dim"))
 end
 
-@propagate_inbounds function _promote_shape(a::Tuple{A,Vararg{Any}}, b::Tuple{B,Vararg{Any}}) where {A,B}
-    (_try_static(getfield(a, 1), getfield(b, 1)), _promote_shape(tail(a), tail(b))...)
-end
-_promote_shape(::Tuple{}, ::Tuple{}) = ()
-@propagate_inbounds function _promote_shape(::Tuple{}, b::Tuple{B}) where {B}
-    (_try_static(static(1), getfield(b, 1)),)
-end
-@propagate_inbounds function _promote_shape(a::Tuple{A}, ::Tuple{}) where {A}
-    (_try_static(static(1), getfield(a, 1)),)
-end
-@propagate_inbounds function Base.promote_shape(a::Tuple{Vararg{CanonicalInt}}, b::Tuple{Vararg{CanonicalInt}})
-    _promote_shape(a, b)
-end
-
 #julia> @btime ArrayInterfaceCore.is_increasing(ArrayInterfaceCore.nstatic(Val(10)))
 #  0.045 ns (0 allocations: 0 bytes)
 #ArrayInterfaceCore.True()

test/dimensions.jl

@@ -108,12 +108,12 @@ end
     @test @inferred(ArrayInterface.known_dimnames(Iterators.flatten(1:10))) === (:_,)
     @test @inferred(ArrayInterface.known_dimnames(Iterators.flatten(1:10), static(1))) === :_
     @test @inferred(ArrayInterface.known_dimnames(z)) === (nothing, :y)
-    @test @inferred(ArrayInterface.known_dimnames(reshape(x, (1, 4)))) == d
-    @test @inferred(ArrayInterface.known_dimnames(r1)) == d
-    @test @inferred(ArrayInterface.known_dimnames(r2)) == (:_, d...)
-    @test @inferred(ArrayInterface.known_dimnames(r3)) == Base.tail(d)
-    @test @inferred(ArrayInterface.known_dimnames(r4)) == d
-    @test @inferred(ArrayInterface.known_dimnames(w)) == d
+    @test @inferred(ArrayInterface.known_dimnames(reshape(x, (1, 4)))) === (:x, :y)
+    @test @inferred(ArrayInterface.known_dimnames(r1)) === (:x, :y)
+    @test @inferred(ArrayInterface.known_dimnames(r2)) === (:_, :x, :y)
+    @test @inferred(ArrayInterface.known_dimnames(r3)) === (:y,)
+    @test @inferred(ArrayInterface.known_dimnames(r4)) === (:x, :y)
+    @test @inferred(ArrayInterface.known_dimnames(w)) === (:x, :y)
     @test @inferred(ArrayInterface.known_dimnames(reshape(x, :))) === (:_,)
     @test @inferred(ArrayInterface.known_dimnames(view(x, :, 1)')) === (:_, :x)
 end