Skip to content

Commit 7281f96

Browse files
authored
Fix stats functions signatures (#22)
1 parent 393a25d commit 7281f96

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/array_of_similar_arrays.jl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -415,26 +415,26 @@ Statistics.mean(X::AbstractVectorOfSimilarArrays{T,M}) where {T,M} =
415415

416416

417417
"""
418-
var(X::AbstractVectorOfSimilarArrays; corrected::Bool = true)
419-
var(X::AbstractVectorOfSimilarArrays, w::StatsBase.AbstractWeights; corrected::Bool = true)
418+
var(X::AbstractVectorOfSimilarArrays; corrected::Bool = true, mean = nothing)
419+
var(X::AbstractVectorOfSimilarArrays, w::StatsBase.AbstractWeights; corrected::Bool = true, mean = nothing)
420420
421421
Compute the sample variance of the elements vectors of `X`. Equivalent to
422422
`var` of `flatview(X)` along the last dimension.
423423
"""
424-
Statistics.var(X::AbstractVectorOfSimilarArrays{T,M}; corrected::Bool = true) where {T,M} =
425-
var(flatview(X); dims = M + 1, corrected = corrected)[_ncolons(Val{M}())...]
424+
Statistics.var(X::AbstractVectorOfSimilarArrays{T,M}; corrected::Bool = true, mean = nothing) where {T,M} =
425+
var(flatview(X); dims = M + 1, corrected = corrected, mean = mean)[_ncolons(Val{M}())...]
426426

427427

428428
"""
429-
var(X::AbstractVectorOfSimilarArrays; corrected::Bool = true)
430-
var(X::AbstractVectorOfSimilarArrays, w::StatsBase.AbstractWeights; corrected::Bool = true)
429+
var(X::AbstractVectorOfSimilarArrays; corrected::Bool = true, mean = nothing)
430+
var(X::AbstractVectorOfSimilarArrays, w::StatsBase.AbstractWeights; corrected::Bool = true, mean = nothing)
431431
432432
Compute the sample standard deviation of the elements vectors of `X`.
433433
Compute the sample variance of the elements vectors of `X`. Equivalent to
434434
`std` of `flatview(X)` along the last dimension.
435435
"""
436-
Statistics.std(X::AbstractVectorOfSimilarArrays{T,M}; corrected::Bool = true) where {T,M} =
437-
std(flatview(X); dims = M + 1, corrected = corrected)[_ncolons(Val{M}())...]
436+
Statistics.std(X::AbstractVectorOfSimilarArrays{T,M}; corrected::Bool = true, mean = nothing) where {T,M} =
437+
std(flatview(X); dims = M + 1, corrected = corrected, mean = mean)[_ncolons(Val{M}())...]
438438

439439

440440
"""

src/statsbase_support.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ Base.sum(X::AbstractVectorOfSimilarArrays{T,M}, w::StatsBase.AbstractWeights) wh
77
Statistics.mean(X::AbstractVectorOfSimilarArrays{T,M}, w::StatsBase.AbstractWeights) where {T,M} =
88
mean(flatview(X), w, dims = M + 1)[_ncolons(Val{M}())...]
99

10-
Statistics.var(X::AbstractVectorOfSimilarArrays{T,M}, w::StatsBase.AbstractWeights; corrected::Bool = true) where {T,M} =
11-
var(flatview(X), w, M + 1; corrected = corrected)[_ncolons(Val{M}())...]
10+
Statistics.var(X::AbstractVectorOfSimilarArrays{T,M}, w::StatsBase.AbstractWeights; mean = nothing, corrected::Bool = true) where {T,M} =
11+
var(flatview(X), w, M + 1; mean = mean, corrected = corrected)[_ncolons(Val{M}())...]
1212

13-
Statistics.std(X::AbstractVectorOfSimilarArrays{T,M}, w::StatsBase.AbstractWeights; corrected::Bool = true) where {T,M} =
14-
std(flatview(X), w, M + 1; corrected = corrected)[_ncolons(Val{M}())...]
13+
Statistics.std(X::AbstractVectorOfSimilarArrays{T,M}, w::StatsBase.AbstractWeights; mean = nothing, corrected::Bool = true) where {T,M} =
14+
std(flatview(X), w, M + 1; mean = mean, corrected = corrected)[_ncolons(Val{M}())...]
1515

1616
Statistics.cov(X::AbstractVectorOfSimilarVectors, w::StatsBase.AbstractWeights; corrected::Bool = true) =
1717
cov(flatview(X), w, 2; corrected = corrected)

0 commit comments

Comments
 (0)