Optimize identity map and broadcast

Author: oschulz

src/array_of_similar_arrays.jl

@@ -221,6 +221,9 @@ function deepmap(f::Base.Callable, A::ArrayOfSimilarArrays{T,M,N}) where {T,M,N}
 end
 
 
+Base.map(::typeof(identity), A::ArrayOfSimilarArrays) = deepcopy(A)
+Base.Broadcast.broadcasted(::typeof(identity), A::ArrayOfSimilarArrays) = deepcopy(A)
+
 
 Base.@pure _result_is_nested(idxs_outer::Tuple, idxs_inner::Tuple) =
     Val{!(Base.index_dimsum(idxs_outer...) isa Tuple{}) && !(Base.index_dimsum(idxs_inner...) isa Tuple{})}()

src/vector_of_arrays.jl

@@ -419,6 +419,11 @@ function deepmap(f::Base.Callable, A::VectorOfArrays)
 end
 
 
+Base.map(::typeof(identity), A::VectorOfArrays) = deepcopy(A)
+Base.Broadcast.broadcasted(::typeof(identity), A::VectorOfArrays) = deepcopy(A)
+
+
+
 """
     VectorOfVectors{T,...} = VectorOfArrays{T,1,...}
 

test/array_of_similar_arrays.jl

@@ -353,4 +353,15 @@ using StatsBase: cov2cor
 
         @test @inferred(ArraysOfArrays._innerlength(VSV)) == N
     end
+
+    @testset "map and broadcast" begin
+        A_flat = rand(2,3,4,5,6)
+        A = nestedview(A_flat, 2)
+
+        for do_map in (map, broadcast)
+            @test @inferred(do_map(identity, A)) == A
+            do_map(identity, A) isa ArrayOfSimilarArrays
+            @test do_map(identity, A) !== A
+        end
+    end
 end

test/vector_of_arrays.jl

@@ -334,4 +334,14 @@ using ArraysOfArrays: full_consistency_checks, append_elemptr!, element_ptr
         @test @inferred(map(Float32, VoA1.data)) == VoA2.data
 
     end
+
+    @testset "map and broadcast" begin
+        A = VectorOfArrays(ref_AoA2(Float32, 4))
+
+        for do_map in (map, broadcast)
+            @test @inferred(do_map(identity, A)) == A
+            do_map(identity, A) isa VectorOfArrays
+            @test do_map(identity, A) !== A
+        end
+    end
 end