Fix indexing VectorOfArrays with logical indices

Author: oschulz

src/vector_of_arrays.jl

@@ -212,8 +212,13 @@ Base.@propagate_inbounds function Base._getindex(l::IndexStyle, A::VectorOfArray
 end
 
 
-Base.@propagate_inbounds function Base._getindex(l::IndexStyle, A::VectorOfArrays, idxs::AbstractVector{<:Integer})
-    @boundscheck checkbounds(A, idxs)
+@inline _explicit_idxs(::AbstractVector, idxs::AbstractVector{<:Integer}) = idxs
+@inline _explicit_idxs(eachidx::AbstractVector, idxs::Base.LogicalIndex) = eachidx[idxs]
+
+Base.@propagate_inbounds function Base._getindex(l::IndexStyle, A::VectorOfArrays, raw_idxs::AbstractVector{<:Integer})
+    @boundscheck checkbounds(A, raw_idxs)
+
+    idxs = _explicit_idxs(eachindex(A), raw_idxs)
 
     A_ep = A.elem_ptr
     A_data = A.data

test/vector_of_arrays.jl

@@ -168,6 +168,10 @@ using ArraysOfArrays: full_consistency_checks, append_elemptr!, element_ptr
 
         @test @inferred(element_ptr(V12)) == V12.elem_ptr
 
+        boolidxs = rand(Bool, length(V1))
+        @test @inferred(V1[boolidxs]) == V1[eachindex(V1)[boolidxs]]
+        
+
 ## _view_reshape_spec not yet implemented ##
 #       V1_copy = copy(V1)
 #       V2_copy = copy(V2)