Fix bug in similar with adjoints/transpose (#180)

* Fix bug in indexing with adjoints/transpose

* Fix adjortrans block indexing

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockArrays"
 uuid = "8e7c35d0-a365-5155-bbbb-fb81a777f24e"
-version = "0.16.3"
+version = "0.16.4"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/blockarray.jl

@@ -357,6 +357,8 @@ end
     BlockArray{T}(undef, axes)
 @inline Base.similar(block_array::AbstractArray, ::Type{T}, axes::Tuple{AbstractUnitRange{Int},BlockedUnitRange,Vararg{AbstractUnitRange{Int}}}) where T =
     BlockArray{T}(undef, axes)
+@inline Base.similar(block_array::AbstractArray, ::Type{T}, axes::Tuple{Int,BlockedUnitRange,Vararg{AbstractUnitRange{Int}}}) where T =
+    similar(block_array, T, (Base.OneTo(axes[1]), tail(axes)...))
 
 @inline Base.similar(block_array::Type{<:AbstractArray{T}}, axes::Tuple{BlockedUnitRange,Vararg{AbstractUnitRange{Int}}}) where T =
     BlockArray{T}(undef, axes)

src/views.jl

@@ -146,6 +146,8 @@ end
 
 Base.view(A::AdjOrTrans{<:Any,<:BlockArray}, K::Block{1}, J::Block{1}) = view(A, Block(Int(K), Int(J)))
 
+@propagate_inbounds getindex(v::LinearAlgebra.AdjOrTransAbsVec, ::Colon, is::AbstractArray{<:Block{1}}) = LinearAlgebra.wrapperop(v)(v.parent[is])
+
 
 unsafe_convert(::Type{Ptr{T}}, V::SubArray{T,N,PseudoBlockArray{T,N,AT},<:Tuple{Vararg{BlockOrRangeIndex}}}) where {T,N,AT} =
     unsafe_convert(Ptr{T}, V.parent) + (Base.first_index(V)-1)*sizeof(T)

test/test_blockarrays.jl

@@ -547,4 +547,12 @@ end
             blockisequal(axes(permutedims(A)), axes(A))
         end
     end
+
+    @testset "adjoint getindex" begin
+        a = BlockVector(1:5, [2,1,1,1])
+        @test similar(a', Int, 1, axes(a,1)) isa BlockMatrix
+        @test (a')[:,Block.(1:2)] == transpose(a)[:,Block.(1:2)] == [1 2 3]
+        @test (a')[:,Block.(1:2)] isa Adjoint
+        @test transpose(a)[:,Block.(1:2)] isa Transpose
+    end
 end