Skip to content

Commit 7f42aa5

Browse files
authored
remove unnecessary promote_rule for BlockedUnitRange (#299)
* remove unnecessary promote_rule * Add promote tests * move tests to new testset
1 parent e54dd1b commit 7f42aa5

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/blockaxis.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ Base.convert(::Type{BlockedUnitRange{CS}}, axis::AbstractUnitRange{Int}) where C
127127

128128
Base.unitrange(b::BlockedUnitRange) = first(b):last(b)
129129

130-
Base.promote_rule(::Type{BlockedUnitRange{CS}}, ::Type{UnitRange{Int}}) where CS = UnitRange{Int}
131130
Base.promote_rule(::Type{BlockedUnitRange{CS}}, ::Type{Base.OneTo{Int}}) where CS = UnitRange{Int}
132131

133132
"""

test/test_blockindices.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,11 @@ import BlockArrays: BlockIndex, BlockIndexRange, BlockSlice
117117
end
118118

119119
@testset "BlockedUnitRange" begin
120+
@testset "promote" begin
121+
b = blockedrange([1,2,3])
122+
@test promote(b, 1:2) == (1:6, 1:2)
123+
@test promote(b, Base.OneTo(2)) == (1:6, 1:2)
124+
end
120125
@testset "Block indexing" begin
121126
b = blockedrange([1,2,3])
122127
@test axes(b) == (b,)

0 commit comments

Comments
 (0)