Change muladd to mul in BlockArray * StridedVector (#272)

* muladd to mul in BlockArray * StridedVector

* bump version to v0.16.33

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockArrays"
 uuid = "8e7c35d0-a365-5155-bbbb-fb81a777f24e"
-version = "0.16.32"
+version = "0.16.33"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/blocklinalg.jl

@@ -208,27 +208,6 @@ end
 # BLAS overrides
 #############
 
-
-function materialize!(M::MatMulVecAdd{<:AbstractBlockLayout,<:AbstractStridedLayout,<:AbstractStridedLayout})
-    α, A, x_in, β, y_in = M.α, M.A, M.B, M.β, M.C
-    if length(x_in) != size(A,2) || length(y_in) != size(A,1)
-        throw(DimensionMismatch())
-    end
-
-    # impose block structure
-    y = PseudoBlockArray(y_in, (axes(A,1),))
-    x = PseudoBlockArray(x_in, (axes(A,2),))
-
-    _fill_lmul!(β, y)
-
-    for J = blockaxes(A,2)
-        for K = blockcolsupport(A,J)
-            muladd!(α, view(A,K,J), view(x,J), one(α), view(y,K))
-        end
-    end
-    y_in
-end
-
 @inline function _block_muladd!(α, A, X::AbstractVector, β, Y::AbstractVector)
     _fill_lmul!(β, Y)
     for N = blockcolsupport(X), K = blockcolsupport(A,N)
@@ -245,6 +224,19 @@ end
     Y
 end
 
+function materialize!(M::MatMulVecAdd{<:AbstractBlockLayout,<:AbstractStridedLayout,<:AbstractStridedLayout})
+    α, A, x_in, β, y_in = M.α, M.A, M.B, M.β, M.C
+    if length(x_in) != size(A,2) || length(y_in) != size(A,1)
+        throw(DimensionMismatch())
+    end
+
+    # impose block structure
+    y = PseudoBlockArray(y_in, (axes(A,1),))
+    x = PseudoBlockArray(x_in, (axes(A,2),))
+    _block_muladd!(α, A, x, β, y)
+    y_in
+end
+
 mul_blockscompatible(A, B, C) = blockisequal(axes(A,2), axes(B,1)) &&
     blockisequal(axes(A,1), axes(C,1)) &&
     blockisequal(axes(B,2), axes(C,2))
@@ -308,7 +300,6 @@ _triangular_matrix(::Val{'L'}, ::Val{'U'}, A) = UnitLowerTriangular(A)
 function _matchingblocks_triangular_mul!(::Val{'U'}, UNIT, A::AbstractMatrix{T}, dest) where T
     # impose block structure
     b = PseudoBlockArray(dest, (axes(A,1),))
-
     for K = blockaxes(A,1)
         b_2 = view(b, K)
         Ũ = _triangular_matrix(Val('U'), UNIT, view(A, K,K))