checkindex BlockedUnitRange with BlockIndex (#242)

* checkindex BlockedUnitRange with BlockIndex

* version bump to v0.16.24

Author: jishnub

src/blockaxis.jl

@@ -253,6 +253,13 @@ Base.dataids(b::BlockedUnitRange) = Base.dataids(blocklasts(b))
 Base.checkindex(::Type{Bool}, b::BlockRange, K::Int) = checkindex(Bool, Int.(b), K)
 Base.checkindex(::Type{Bool}, b::AbstractUnitRange{Int}, K::Block{1}) = checkindex(Bool, blockaxes(b,1), Int(K))
 
+function Base.checkindex(::Type{Bool}, axis::BlockedUnitRange, ind::BlockIndexRange{1})
+    checkindex(Bool, axis, first(ind)) && checkindex(Bool, axis, last(ind))
+end
+function Base.checkindex(::Type{Bool}, axis::BlockedUnitRange, ind::BlockIndex{1})
+    checkindex(Bool, axis, block(ind)) && checkbounds(Bool, axis[block(ind)], blockindex(ind))
+end
+
 function getindex(b::AbstractUnitRange{Int}, K::Block{1})
     @boundscheck K == Block(1) || throw(BlockBoundsError(b, K))
     b

test/test_blockindices.jl

@@ -296,10 +296,32 @@ end
         @test checkindex(Bool, b, Block(1))
         @test checkindex(Bool, b, Block(3))
         @test !checkindex(Bool, b, Block(4))
+        # treat b as the array, and check against the axis of b
         @test checkbounds(Bool, b, Block(1)[1])
+        @test checkbounds(Bool, b, Block(1)[1:1])
         @test !checkbounds(Bool, b, Block(1)[2])
+        @test checkbounds(Bool, b, Block(2)[1])
+        @test checkbounds(Bool, b, Block(2)[1:2])
+        @test !checkbounds(Bool, b, Block(2)[3])
+        @test checkbounds(Bool, b, Block(3)[1])
+        @test checkbounds(Bool, b, Block(3)[3])
+        @test checkbounds(Bool, b, Block(3)[1:3])
+        @test !checkbounds(Bool, b, Block(3)[4])
         @test !checkbounds(Bool, b, Block(0)[1])
         @test !checkbounds(Bool, b, Block(1)[0])
+        # treat b as the axis
+        @test checkindex(Bool, b, Block(1)[1])
+        @test checkindex(Bool, b, Block(1)[1:1])
+        @test !checkindex(Bool, b, Block(1)[2])
+        @test checkindex(Bool, b, Block(2)[1])
+        @test checkindex(Bool, b, Block(2)[1:2])
+        @test !checkindex(Bool, b, Block(2)[3])
+        @test checkindex(Bool, b, Block(3)[1])
+        @test checkindex(Bool, b, Block(3)[3])
+        @test checkindex(Bool, b, Block(3)[1:3])
+        @test !checkindex(Bool, b, Block(3)[4])
+        @test !checkindex(Bool, b, Block(0)[1])
+        @test !checkindex(Bool, b, Block(1)[0])
     end
 
     @testset "Slice" begin