fix BlockedArray

Author: ogauthe

src/blockarray.jl

@@ -455,7 +455,7 @@ end
 
 # specific 0-dim
 @inline Base.similar(B::BlockArray{<:Any,0}, ::Type{T}) where {T} = BlockArray(similar(only(blocks(B)), T), ())
-@inline Base.similar(::BlockArray, ::Type{T}, ::Tuple{}) where {T} = BlockArray(Array{T}(undef))
+@inline Base.similar(::BlockArray, ::Type{T}, ::Tuple{}) where {T} = BlockArray{T}(undef)
 
 const OffsetAxis = Union{Integer, UnitRange, Base.OneTo, Base.IdentityUnitRange}
 

src/blockedarray.jl

@@ -204,7 +204,7 @@ function Base.similar(block_array::BlockedArray{T,N}, ::Type{T2}) where {T,N,T2}
 end
 
 # specific zero dim
-Base.similar(::BlockedArray{<:Any,0}, ::Type{T}, ::Tuple{}) where {T} = BlockedArray(Array{T}(undef))
+Base.similar(::BlockedArray, ::Type{T}, ::Tuple{}) where {T} = BlockedArray{T}(undef)
 
 to_axes(r::AbstractUnitRange) = r
 to_axes(n::Integer) = Base.oneto(n)

test/test_blockarrays.jl

@@ -325,6 +325,7 @@ end
 
         @testset "zero dim" begin
             zerodim = ones()
+            r = blockedrange([1])
             @test view(zerodim) isa AbstractArray{Float64, 0}  #  check no type-piracy
 
             ret = BlockArray{Float64}(undef)
@@ -352,7 +353,8 @@ end
             @test similar(ret) isa BlockArray{Float64, 0}
             @test similar(ret, Float32) isa BlockArray{Float32, 0}
             @test similar(ret, Float32, ()) isa BlockArray{Float32, 0}
-            @test similar(ret, Float32, (blockedrange([1]),)) isa BlockVector{Float32}
+            @test similar(ret, Float32, (r,)) isa BlockVector{Float32}
+            @test similar(BlockArray(zeros(r)), Float32, ()) isa BlockArray{Float32, 0}
 
             ret = BlockArray(zeros(1,1))
             @test reshape(ret, ()) isa AbstractBlockArray{Float64, 0}  # may be BlockedArray
@@ -382,6 +384,7 @@ end
             @test similar(ret, Float32) isa BlockedArray{Float32, 0}
             @test similar(ret, Float32, ()) isa BlockedArray{Float32, 0}
             @test similar(ret, Float32, (blockedrange([1]),)) isa BlockedVector{Float32}
+            @test similar(zeros(r), Float32, ()) isa BlockedArray{Float32, 0}
 
             ret = BlockedArray(zeros(1,1))
             @test reshape(ret, ()) isa BlockedArray{Float64, 0}