Change lmul! to rmul! in _block_muladd! (#324)

* Change lmul to rmul in _block_muladd

* Bump version to v0.16.39

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockArrays"
 uuid = "8e7c35d0-a365-5155-bbbb-fb81a777f24e"
-version = "0.16.38"
+version = "0.16.39"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/BlockArrays.jl

@@ -39,7 +39,7 @@ import Base: (:), IteratorSize, iterate, axes1, strides, isempty
 import Base.Broadcast: broadcasted, DefaultArrayStyle, AbstractArrayStyle, Broadcasted, broadcastable
 import LinearAlgebra: lmul!, rmul!, AbstractTriangular, HermOrSym, AdjOrTrans,
                         StructuredMatrixStyle, cholesky, cholesky!, cholcopy, RealHermSymComplexHerm
-import ArrayLayouts: _fill_lmul!, MatMulVecAdd, MatMulMatAdd, MatLmulVec, MatLdivVec,
+import ArrayLayouts: zero!, MatMulVecAdd, MatMulMatAdd, MatLmulVec, MatLdivVec,
                         materialize!, MemoryLayout, sublayout, transposelayout, conjlayout,
                         triangularlayout, triangulardata, _inv, _copyto!, axes_print_matrix_row,
                         colsupport, rowsupport, sub_materialize, sub_materialize_axes, zero!

src/blocklinalg.jl

@@ -202,16 +202,18 @@ end
 # BLAS overrides
 #############
 
+_fill_rmul!(A::AbstractArray, β) = iszero(β) ? zero!(A) : rmul!(A, β)
+
 @inline function _block_muladd!(α, A, X::AbstractVector, β, Y::AbstractVector)
-    _fill_lmul!(β, Y)
+    _fill_rmul!(Y, β)
     for N = blockcolsupport(X), K = blockcolsupport(A,N)
         mul!(view(Y,K), view(A,K,N), view(X,N), α, one(β))
     end
     Y
 end
 
 @inline function _block_muladd!(α, A, X, β, Y)
-    _fill_lmul!(β, Y)
+    _fill_rmul!(Y, β)
     for J = blockaxes(X,2), N = blockcolsupport(X,J), K = blockcolsupport(A,N)
         mul!(view(Y,K,J), view(A,K,N), view(X,N,J), α, one(α))
     end