Fix indexing with adjoints of block vectors

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockArrays"
 uuid = "8e7c35d0-a365-5155-bbbb-fb81a777f24e"
-version = "0.16.12"
+version = "0.16.13"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/abstractblockarray.jl

@@ -106,6 +106,9 @@ end
         @inbounds _i = i[idx]
         Block(_i) in n[k] || return false
     end
+    for idx = N+1:length(i)
+        isone(i[idx]) || return false
+    end
     return true
 end
 

src/views.jl

@@ -148,15 +148,26 @@ _block_reindex(b::Slice, i::Block{1}) = i
 
 
 
-function Base.view(A::Adjoint{<:Any,<:BlockArray}, b::Block{2})
+function Base.view(A::Adjoint{<:Any,<:BlockMatrix}, b::Block{2})
     k, j = b.n
     view(parent(A), Block(j), Block(k))'
 end
-function Base.view(A::Transpose{<:Any,<:BlockArray}, b::Block{2})
+function Base.view(A::Transpose{<:Any,<:BlockMatrix}, b::Block{2})
     k, j = b.n
     transpose(view(parent(A), Block(j), Block(k)))
 end
 
+function Base.view(A::Adjoint{<:Any,<:BlockVector}, b::Block{2})
+    @boundscheck blockcheckbounds(A, b)
+    k, j = b.n
+    view(parent(A), Block(j))'
+end
+function Base.view(A::Transpose{<:Any,<:BlockVector}, b::Block{2})
+    @boundscheck blockcheckbounds(A, b)
+    k, j = b.n
+    transpose(view(parent(A), Block(j)))
+end
+
 Base.view(A::AdjOrTrans{<:Any,<:BlockArray}, K::Block{1}, J::Block{1}) = view(A, Block(Int(K), Int(J)))
 
 @propagate_inbounds getindex(v::LinearAlgebra.AdjOrTransAbsVec, ::Colon, is::AbstractArray{<:Block{1}}) = LinearAlgebra.wrapperop(v)(v.parent[is])

test/test_blockviews.jl

@@ -291,4 +291,18 @@ bview(a, b) = Base.invoke(view, Tuple{AbstractArray,Any}, a, b)
         v = bview(a,Block(1))
         @test view(a, parentindices(v)...) ≡ 7:9
     end
+
+    @testset "BlockVector' view" begin
+        v = BlockArray(randn(3),1:2)
+        @test view(v',Block(1,2)) === view(v,Block(2))'
+        @test view(transpose(v),Block(1,2)) === transpose(view(v,Block(2)))
+
+        @test_throws BlockBoundsError v'[Block(2,2)]
+        @test_throws BlockBoundsError transpose(v)[Block(2,2)]
+    end
+
+    @testset "array indexing past ndims" begin
+        v = BlockArray(randn(3),1:2)
+        @test_broken @test_throws BlockBoundsError v[Block(1,2)]
+    end
 end