Fix ambiguity error in similar with 3 or more blocked axes
#494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 94.52% 94.37% -0.16%
==========================================
Files 19 19
Lines 1789 1812 +23
==========================================
+ Hits 1691 1710 +19
- Misses 98 102 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
similarcalls such as:(with inputs of 3 or more blocked axes) lead to ambiguity errors between the
StridedArrayandAbstractArrayversions which outputBlockedArrayandBlockArrayrespectively, this PR fixes that ambiguity by defining a more specializedsimilarmethod only forAbstractBlockedUnitRangeinputs. The existing definitions accept mixtures of blocked, non-blocked, and integer dimensions which is more prone to ambiguities.Related to #196 and #489.
I also noticed these definitions are not so friendly for GPU array types but that is a separate matter...