Skip to content

Commit 4809427

Browse files
authored
don't specialize convert (#192)
Co-authored-by: Jishnu Bhattacharya <[email protected]>
1 parent 83aeb5b commit 4809427

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/FillArrays.jl

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -433,17 +433,12 @@ end
433433

434434

435435
## Array
436-
convert(::Type{Array}, F::AbstractFill) = fill(getindex_value(F), size(F))
437-
convert(::Type{Array{T}}, F::AbstractFill) where T = fill(convert(T, getindex_value(F)), size(F))
438-
convert(::Type{Array{T,N}}, F::AbstractFill{V,N}) where {T,V,N} = fill(convert(T, getindex_value(F)), size(F))
439-
436+
Base.Array{T,N}(F::AbstractFill{V,N}) where {T,V,N} = fill(convert(T, getindex_value(F)), size(F))
440437

441438
# These are in case `zeros` or `ones` are ever faster than `fill`
442439
for (Typ, funcs, func) in ((:Zeros, :zeros, :zero), (:Ones, :ones, :one))
443440
@eval begin
444-
convert(::Type{Array}, F::$Typ{T}) where T = $funcs(T, size(F))
445-
convert(::Type{Array{T}}, F::$Typ{T}) where T = $funcs(T, size(F))
446-
convert(::Type{Array{T,N}}, F::$Typ{V,N}) where {T,V,N} = $funcs(T,size(F))
441+
Base.Array{T,N}(F::$Typ{V,N}) where {T,V,N} = $funcs(T,size(F))
447442
end
448443
end
449444

0 commit comments

Comments
 (0)