Fix adjoint-Diagonal multiplication for non-square elements (#317)

* Diagonal mul zerosadj ambiguity

* missing adjoint in adj-diag mul

* Fix test for non-square

Author: jishnub

src/fillalgebra.jl

@@ -300,7 +300,8 @@ end
 
 *(a::Adjoint{T, <:AbstractMatrix{T}} where T, b::AbstractZeros{<:Any, 1}) = mult_zeros(a, b)
 
-*(a::AdjointAbsVec{<:Any,<:AbstractZerosVector}, D::Diagonal) = (D*a')'
+*(D::Diagonal, a::AdjointAbsVec{<:Any,<:AbstractZerosVector}) = (a' * D')'
+*(a::AdjointAbsVec{<:Any,<:AbstractZerosVector}, D::Diagonal) = (D' * a')'
 *(a::TransposeAbsVec{<:Any,<:AbstractZerosVector}, D::Diagonal) = transpose(D*transpose(a))
 function _triple_zeromul(x, D::Diagonal, y)
     if !(length(x) == length(D.diag) == length(y))

test/runtests.jl

@@ -1487,6 +1487,14 @@ end
         D = Diagonal([[1 2; 3 4], [1 2 3; 4 5 6]])
         @test @inferred(Zeros(TSM, 2,2) * D) == zeros(TSM, 2,2) * D
 
+        D = Diagonal(fill(SMatrix{2,3}(fill(im,6)),1))
+        Z = Zeros(SMatrix{2,3,ComplexF64,6},1)
+        @test D * Z' == fill(zero(SMatrix{2,2,ComplexF64,4}),1,1)
+
+        D = Diagonal(fill(zeros(2,3), 2))
+        Z = Zeros(SMatrix{2,3,Float64,6}, 2)
+        @test Z' * D == Array(Z)' * D
+
         # doubly nested
         A = [[[1,2]]]'
         Z = Zeros(SMatrix{1,1,SMatrix{2,2,Int,4},1},1)