Fix sorting for purely imag value

Author: jishnub

Project.toml

@@ -1,23 +1,13 @@
 name = "FillArrays"
 uuid = "1a297f60-69ca-5386-bcde-b61e274b549b"
-version = "1.11"
+version = "1.11.0"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 PDMats = "90014a1f-27ba-587c-ab20-58faa44d9150"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
-[weakdeps]
-PDMats = "90014a1f-27ba-587c-ab20-58faa44d9150"
-SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
-Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
-
-[extensions]
-FillArraysPDMatsExt = "PDMats"
-FillArraysSparseArraysExt = "SparseArrays"
-FillArraysStatisticsExt = "Statistics"
-
 [compat]
 Aqua = "0.8"
 Base64 = "1.6"
@@ -34,6 +24,11 @@ Statistics = "1.6"
 Test = "1.6"
 julia = "1.6"
 
+[extensions]
+FillArraysPDMatsExt = "PDMats"
+FillArraysSparseArraysExt = "SparseArrays"
+FillArraysStatisticsExt = "Statistics"
+
 [extras]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
@@ -50,3 +45,8 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
 test = ["Aqua", "Test", "Base64", "Infinities", "PDMats", "ReverseDiff", "SparseArrays", "StaticArrays", "Statistics", "Quaternions", "Documenter", "Random"]
+
+[weakdeps]
+PDMats = "90014a1f-27ba-587c-ab20-58faa44d9150"
+SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
+Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"

test/runtests.jl

@@ -2756,16 +2756,18 @@ end
 @testset "eigen" begin
     sortby = x -> (real(x), imag(x))
     @testset "AbstractFill" begin
-        @testset for val in (2.0, -2, 3+2im, 4 - 5im, 2im), n in (VERSION >= v"1.10" ? (0, 1, 4) : (1, 4))
+        sizes = VERSION >= v"1.10" ? (0, 1, 4) : (1, 4)
+        @testset for val in (2.0, -2, 3+2im, 4 - 5im, 2im), n in sizes
+            sortby_val = iszero(real(val)) ? imag : sortby
             F = Fill(val, n, n)
             M = Matrix(F)
-            @test eigvals(F; sortby) ≈ eigvals(M; sortby)
-            λ, V = eigen(F; sortby)
-            @test λ == eigvals(F; sortby)
+            @test eigvals(F; sortby = sortby_val) ≈ eigvals(M; sortby = sortby_val)
+            λ, V = eigen(F; sortby = sortby_val)
+            @test λ == eigvals(F; sortby = sortby_val)
             @test V'V ≈ I
             @test F * V ≈ V * Diagonal(λ)
         end
-        @testset for MT in (Ones, Zeros), T in (Float64, Int, ComplexF64), n in (0, 1, 4)
+        @testset for MT in (Ones, Zeros), T in (Float64, Int, ComplexF64), n in sizes
             F = MT{T}(n,n)
             M = Matrix(F)
             @test eigvals(F; sortby) ≈ eigvals(M; sortby)