Skip to content

Commit d357eac

Browse files
authored
Less verbose show for Eye (#118)
* Less verbose show for Eye * Add test * Update runtests.jl
1 parent 7a07049 commit d357eac

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "FillArrays"
22
uuid = "1a297f60-69ca-5386-bcde-b61e274b549b"
3-
version = "0.9.4"
3+
version = "0.9.5"
44

55
[deps]
66
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/FillArrays.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -589,10 +589,10 @@ Base.print_matrix_row(io::IO,
589589

590590

591591
# Display concise description of a Fill.
592-
Base.show(io::IO, x::AbstractFill) =
593-
print(io, "$(summary(x)): entries equal to $(getindex_value(x))")
594-
Base.show(io::IO, x::Union{Zeros,Ones}) =
595-
print(io, "$(summary(x))")
592+
593+
594+
Base.show(io::IO, x::AbstractFill) = print(io, "$(summary(x)): entries equal to $(getindex_value(x))")
595+
Base.show(io::IO, x::Union{Zeros,Ones,Eye}) = print(io, "$(summary(x))")
596596

597597
if VERSION  v"1.5"
598598
Base.array_summary(io::IO, ::Zeros{T}, inds::Tuple{Vararg{Base.OneTo}}) where T =
@@ -601,10 +601,10 @@ if VERSION ≥ v"1.5"
601601
print(io, Base.dims2string(length.(inds)), " Ones{$T}")
602602
Base.array_summary(io::IO, a::Fill{T}, inds::Tuple{Vararg{Base.OneTo}}) where T =
603603
print(io, Base.dims2string(length.(inds)), " Fill{$T}")
604+
Base.array_summary(io::IO, a::Eye{T}, inds::Tuple{Vararg{Base.OneTo}}) where T =
605+
print(io, Base.dims2string(length.(inds)), " Eye{$T}")
604606
end
605607

606-
function Base.show(io::IO, ::MIME"text/plain", x::AbstractFill)
607-
show(io, x)
608-
end
608+
Base.show(io::IO, ::MIME"text/plain", x::Union{Eye,AbstractFill}) = show(io, x)
609609

610610
end # module

test/runtests.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1010,10 +1010,11 @@ if VERSION ≥ v"1.5"
10101010
@testset "print" begin
10111011
@test stringmime("text/plain", Zeros(3)) == "3-element Zeros{Float64}"
10121012
@test stringmime("text/plain", Ones(3)) == "3-element Ones{Float64}"
1013-
@test stringmime("text/plain", Fill(7,2)) == "2-element Fill{Int64}: entries equal to 7"
1013+
@test stringmime("text/plain", Fill(7,2)) == "2-element Fill{$Int}: entries equal to 7"
10141014
@test stringmime("text/plain", Zeros(3,2)) == "3×2 Zeros{Float64}"
10151015
@test stringmime("text/plain", Ones(3,2)) == "3×2 Ones{Float64}"
1016-
@test stringmime("text/plain", Fill(7,2,3)) == "2×3 Fill{Int64}: entries equal to 7"
1016+
@test stringmime("text/plain", Fill(7,2,3)) == "2×3 Fill{$Int}: entries equal to 7"
1017+
@test stringmime("text/plain", Eye(5)) == "5×5 Eye{Float64}"
10171018
end
10181019
end
10191020

0 commit comments

Comments
 (0)