align checked_dims with Base by rejecting typemax(Int) (#39)

Author: nsajko

src/FixedSizeArrays.jl

@@ -50,6 +50,10 @@ Base.isassigned(a::FixedSizeArray, i::Int) = isassigned(a.mem, i)
 checked_dims_impl(a::Int, ::Tuple{}) = a
 function checked_dims_impl(a::Int, t::Tuple{Int,Vararg{Int,N}}) where {N}
     b = first(t)
+    tmax = typemax(a)
+    if (a == tmax) || (b == tmax)
+        throw(ArgumentError("array dimension size can't be the maximum representable value"))
+    end
     if (a < 0) || (b < 0)
         throw(ArgumentError("array dimension size can't be negative"))
     end

test/runtests.jl

@@ -57,9 +57,10 @@ end
         @test_throws ArgumentError FixedSizeArray{Float64,1}(undef, -1)
         @test_throws ArgumentError FixedSizeArray{Float64,1}(undef, (-1,))
         @test_throws ArgumentError FixedSizeArray{Float64,2}(undef, -1, -1)
+        @test_throws ArgumentError FixedSizeArray{Float64,2}(undef, typemax(Int), 0)
         @test_throws ArgumentError FixedSizeArray{Float64,2}(undef, typemax(Int), typemax(Int))
-        @test_throws ArgumentError FixedSizeArray{Float64,3}(undef, typemax(Int), typemax(Int), 2)
-        @test_throws ArgumentError FixedSizeArray{Float64,4}(undef, typemax(Int), typemax(Int), 2, 4)
+        @test_throws ArgumentError FixedSizeArray{Float64,3}(undef, typemax(Int)-1, typemax(Int)-1, 2)
+        @test_throws ArgumentError FixedSizeArray{Float64,4}(undef, typemax(Int)-1, typemax(Int)-1, 2, 4)
         @testset "negative dimension size" begin
             for n ∈ 2:4
                 funs = (