increase codecov

Author: dlfivefifty

ext/InfiniteArraysBandedMatricesExt.jl

@@ -5,7 +5,7 @@ using InfiniteArrays.LazyArrays, InfiniteArrays.ArrayLayouts, InfiniteArrays.Fil
 import Base: BroadcastStyle, size, getindex, similar, copy, *, +, -, /, \, materialize!, copyto!, OneTo
 import Base.Broadcast: Broadcasted
 import InfiniteArrays: InfIndexRanges, Infinity, PosInfinity, OneToInf, InfAxes, AbstractInfUnitRange, InfRanges
-import ArrayLayouts: sub_materialize, MemoryLayout, sublayout, mulreduce, _bidiag_forwardsub!, triangularlayout, MatLdivVec
+import ArrayLayouts: sub_materialize, MemoryLayout, sublayout, mulreduce, triangularlayout, MatLdivVec, subdiagonaldata, diagonaldata, supdiagonaldata
 import LazyArrays: applybroadcaststyle, applylayout, islazy, islazy_layout, simplifiable, AbstractLazyLayout, PaddedColumns, LazyArrayStyle, ApplyLayout, AbstractLazyBandedLayout, ApplyBandedLayout, BroadcastBandedLayout
 import BandedMatrices: _BandedMatrix, AbstractBandedMatrix, banded_similar, BandedMatrix, bandedcolumns, BandedColumns, bandeddata
 import FillArrays: AbstractFillMatrix, AbstractFill, getindex_value
@@ -472,37 +472,6 @@ mulreduce(M::Mul{<:DiagonalLayout, <:InfToeplitzLayouts}) = Lmul(M)
 mulreduce(M::Mul{<:InfToeplitzLayouts, <:DiagonalLayout}) = Rmul(M)
 
 
-function _bidiag_forwardsub!(M::Ldiv{<:Any,<:PaddedColumns})
-    A, b_in = M.A, M.B
-    dv = diagonaldata(A)
-    ev = subdiagonaldata(A)
-    b = paddeddata(b_in)
-    N = length(b)
-    b[1] = bj1 = dv[1]\b[1]
-    @inbounds for j = 2:N
-        bj  = b[j]
-        bj -= ev[j - 1] * bj1
-        dvj = dv[j]
-        if iszero(dvj)
-            throw(SingularEbception(j))
-        end
-        bj   = dvj\bj
-        b[j] = bj1 = bj
-    end
-
-    @inbounds for j = N+1:length(b_in)
-        iszero(bj1) && break
-        bj = -ev[j - 1] * bj1
-        dvj = dv[j]
-        if iszero(dvj)
-            throw(SingularEbception(j))
-        end
-        bj   = dvj\bj
-        b_in[j] = bj1 = bj
-    end
-
-    b_in
-end
 
 ###
 # Inf-Toeplitz layout

test/test_infbanded.jl

@@ -14,9 +14,12 @@ const BidiagonalToeplitzLayout = InfiniteArraysBandedMatricesExt.BidiagonalToepl
 const PertToeplitz = InfiniteArraysBandedMatricesExt.PertToeplitz
 const PertToeplitzLayout = InfiniteArraysBandedMatricesExt.PertToeplitzLayout
 const InfBandCartesianIndices = InfiniteArraysBandedMatricesExt.InfBandCartesianIndices
+const subdiagonalconstant = InfiniteArraysBandedMatricesExt.subdiagonalconstant
+const diagonalconstant = InfiniteArraysBandedMatricesExt.diagonalconstant
+const supdiagonalconstant = InfiniteArraysBandedMatricesExt.supdiagonalconstant
 
 using Base: oneto
-using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout
+using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout, islazy
 
 @testset "∞-banded" begin
     @testset "Diagonal and BandedMatrix" begin
@@ -51,7 +54,7 @@ using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout
         @test A isa InfToeplitz
         @test MemoryLayout(A.data) == ConstRows()
         @test MemoryLayout(A) == BandedToeplitzLayout()
-        @test LazyArrays.islazy(A) == Val(true)
+        @test islazy(A) == Val(true)
 
         V = view(A,:,3:∞)
         @test MemoryLayout(typeof(bandeddata(V))) == ConstRows()
@@ -82,9 +85,14 @@ using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout
             T = Tridiagonal(Fill(1,∞), Fill(2,∞), Fill(3,∞))
             @test T isa TriToeplitz
             @test (T + 2I)[1:10,1:10] == (2I + T)[1:10,1:10] == T[1:10,1:10] + 2I
+            @test BandedMatrix(T, (2,3))[1:10,1:10] == InfToeplitz(T,(3,2))[1:10,1:10] == InfToeplitz(T)[1:10,1:10] == T[1:10,1:10]
+            @test subdiagonalconstant(T) == 1
+            @test diagonalconstant(T) == 2
+            @test supdiagonalconstant(T) == 3
 
             S = SymTridiagonal(Fill(1,∞), Fill(2,∞))
             @test (S + 2I)[1:10,1:10] == (2I + S)[1:10,1:10] == S[1:10,1:10] + 2I
+            @test BandedMatrix(S, (2,3))[1:10,1:10] == S[1:10,1:10]
         end
 
         @testset "constant data" begin
@@ -118,9 +126,11 @@ using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout
             A = BandedMatrix(-2 => Vcat(Float64[], Fill(1/4,∞)), 0 => Vcat([1.0+im,2,3],Fill(0,∞)), 1 => Vcat(Float64[], Fill(1,∞)))
             @test A isa PertToeplitz
             @test MemoryLayout(A) isa PertToeplitzLayout
+
             V = view(A,2:∞,2:∞)
             @test MemoryLayout(V) isa PertToeplitzLayout
             @test BandedMatrix(V) isa PertToeplitz
+            @test islazy(V) == Val(true)
             @test A[2:∞,2:∞] isa PertToeplitz
 
             @test (A + 2I)[1:10,1:10] == (2I + A)[1:10,1:10] == A[1:10,1:10] + 2I
@@ -133,14 +143,18 @@ using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout
             A = SymTridiagonal(Vcat([1,2.], Fill(2.,∞)), Vcat([3.,4.], Fill.(0.5,∞)))
             @test A isa SymTriPertToeplitz
             @test (A + 2I)[1:10,1:10] == (2I + A)[1:10,1:10] == A[1:10,1:10] + 2I
+            @test BandedMatrix(A, (2,3))[1:10,1:10] == A[1:10,1:10]
 
             A = Tridiagonal(Vcat([3.,4.], Fill.(0.5,∞)), Vcat([1,2.], Fill(2.,∞)), Vcat([3.,4.], Fill.(0.5,∞)))
             @test A isa TriPertToeplitz
             @test Adjoint(A) isa AdjTriPertToeplitz
             @test (A + 2I)[1:10,1:10] == (2I + A)[1:10,1:10] == A[1:10,1:10] + 2I
             @test (Adjoint(A) + 2I)[1:10,1:10] == (2I + Adjoint(A))[1:10,1:10] == Adjoint(A)[1:10,1:10] + 2I
+            @test BandedMatrix(A, (2,3))[1:10,1:10] == A[1:10,1:10]
         end
 
+
+
         @testset "InfBanded" begin
             A = _BandedMatrix(Fill(2,4,∞),ℵ₀,2,1)
             B = _BandedMatrix(Fill(3,2,∞),ℵ₀,-1,2)
@@ -213,7 +227,7 @@ using LazyArrays: simplifiable, ApplyLayout, BroadcastBandedLayout
         @test A[band(2)][1:5] == [1; fill(2,4)]
         @test A[band(4)] ≡ Zeros{Int}(∞)
     end
-    
+
     @testset "prepad with fill" begin
         A = BandedMatrix(2 => Zeros(∞))
         @test A[band(2)][1:10] == Zeros(10)