Fix cache colsupport

Author: dlfivefifty

src/cache.jl

@@ -118,13 +118,15 @@ function resizedata!(B::CachedArray{T,N,Array{T,N}},nm::Vararg{Integer,N}) where
 end
 
 
-_minimum(a) = isempty(a) ? length(a)+1 : minimum(a)
-_maximum(a) = isempty(a) ? 0 : maximum(a)
-convexunion(a::AbstractVector, b::AbstractVector) = min(_minimum(a),_minimum(b)):max(_maximum(a),_maximum(b))
+function convexunion(a::AbstractVector, b::AbstractVector) 
+    isempty(a) && return b
+    isempty(b) && return a
+    min(minimum(a),minimum(b)):max(maximum(a),maximum(b))
+end
 
-colsupport(A::CachedMatrix, i) = convexunion(colsupport(A.array, i),colsupport(A.data,i))
+colsupport(A::CachedMatrix, i) = i ≤ size(A.data,2) ? convexunion(colsupport(A.array, i),colsupport(A.data,i)) : colsupport(A.array, i)
 colsupport(A::CachedVector, i) = convexunion(colsupport(A.array, i),colsupport(A.data,i))
-rowsupport(A::CachedMatrix, i) = convexunion(rowsupport(A.array, i),rowsupport(A.data,i))
+rowsupport(A::CachedMatrix, i) = i ≤ size(A.data,1) ? convexunion(rowsupport(A.array, i),rowsupport(A.data,i)) : rowsupport(A.array, i)
 
 Base.replace_in_print_matrix(A::CachedMatrix, i::Integer, j::Integer, s::AbstractString) =
     i in colsupport(A,j) ? s : Base.replace_with_centered_mark(s)

test/runtests.jl

@@ -165,6 +165,11 @@ end
         @test_throws BoundsError C[3,1]
         @test_throws BoundsError C[7]
     end
+
+    @testset "colsupport past size" begin
+        C = cache(Zeros(5,5)); C[5,1]; 
+        @test colsupport(C,3) == 1:0
+    end
 end
 
 @testset "Diff and Cumsum" begin
@@ -207,8 +212,8 @@ end
     Z = Zeros(5)
     @test rowsupport(Z,1) === colsupport(Z,1) === 1:0
     @test_broken cache(D)
-    C = cache(Array,D)
-    @test colsupport(C,2) === 1:2
+    C = cache(Array,D);
+    @test colsupport(C,2) === 2:2
     @test colsupport(C,1) === 1:1
     @test colsupport(cache(Zeros(5,5)),1) == 1:0
     C = cache(Zeros(5));
@@ -219,4 +224,7 @@ end
     LazyArrays.zero!(C)
     @test colsupport(C,1) == 1:3
     @test C == zeros(5)
+
+    # bug from BandedMartrices.jl
+    @test LazyArrays.convexunion(7:10,9:8) == LazyArrays.convexunion(9:8,7:10) == 7:10
 end