Add == for Zeros-backed CachedArrays (#328)

* Add == for CacheArrays

* Test

* rm extra using

* Add better tests, fix definition for unequal axes

* Fix namespace

* Move the test to a better file

Author: DanielVandH

Project.toml

@@ -1,6 +1,6 @@
 name = "LazyArrays"
 uuid = "5078a376-72f3-5289-bfd5-ec5146d43c02"
-version = "2.1.2"
+version = "2.1.3"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/padded.jl

@@ -125,6 +125,14 @@ function ==(A::CachedVector{<:Any,<:Any,<:Zeros}, B::CachedVector{<:Any,<:Any,<:
     view(A.data,OneTo(n)) == view(B.data,OneTo(n))
 end
 
+function ==(A::CachedArray{<:Any,<:Any,<:Any,<:Zeros}, B::CachedArray{<:Any,<:Any,<:Any,<:Zeros})
+    size(A) == size(B) || return false
+    m = max(A.datasize[1], B.datasize[1])
+    n = max(A.datasize[2], B.datasize[2])
+    resizedata!(A, m, n); resizedata!(B, m, n)
+    view(A.data, OneTo(m), OneTo(n)) == view(B.data, OneTo(m), OneTo(n))
+end
+
 function copyto!_layout(::PaddedColumns, ::PaddedColumns, dest::AbstractVector, src::AbstractVector)
     length(src) ≤ length(dest)  || throw(BoundsError())
     src_data = paddeddata(src)

test/cachetests.jl

@@ -8,6 +8,7 @@ import LazyArrays: CachedArray, CachedMatrix, CachedVector, PaddedLayout, Cached
 
 include("infinitearrays.jl")
 using .InfiniteArrays
+using .InfiniteArrays: OneToInf
 using Infinities
 
 @testset "Cache" begin
@@ -456,6 +457,35 @@ using Infinities
         view(a, 2:ℵ₀) .= 0.0;
         @test a[1:5] == zeros(5)
     end
+
+    
+    @testset "Issue #327" begin
+        A = cache(Zeros((1:5, OneToInf())))
+        B = cache(Zeros((1:5, OneToInf())))
+        @test A == B
+        A[2, 7] = 2.0
+        @test A ≠ B
+        B[2, 7] = 2.0 
+        @test A == B
+
+        A = cache(Zeros((OneToInf(), 1:7)))
+        B = cache(Zeros((OneToInf(), 1:10)))
+        @test A ≠ B 
+        B = cache(Zeros((OneToInf(), 1:7)))
+        @test A == B 
+        B[2, 2] = 1.0
+        @test A ≠ B 
+        A[2, 2] = 1.0 
+        @test A == B 
+
+        A = cache(Zeros((OneToInf(), OneToInf())))
+        B = cache(Zeros((OneToInf(), OneToInf())))
+        @test A == B 
+        A[5, 7] = 3.4
+        @test A ≠ B 
+        B[5, 7] = 3.4
+        @test A == B
+    end
 end
 
 end # module

test/paddedtests.jl

@@ -7,6 +7,9 @@ import ArrayLayouts: OnesLayout
 import Base: setindex
 using LinearAlgebra
 
+include("infinitearrays.jl")
+using .InfiniteArrays: OneToInf
+
 # padded block arrays have padded data that is also padded. This is to test this
 struct PaddedPadded <: LayoutVector{Int} end