remove unnecessary broadcasting in firstindex/lastindex (#177)

* remove broadcasting in firstindex/lastindex

* version bump to v1.4.3

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "OffsetArrays"
 uuid = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
-version = "1.4.2"
+version = "1.4.3"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

src/axes.jl

@@ -133,8 +133,8 @@ offset_coerce(::Type{I}, r::AbstractUnitRange) where I<:AbstractUnitRange =
 Base.reduced_index(i::IdOffsetRange) = typeof(i)(first(i):first(i))
 # Workaround for #92 on Julia < 1.4
 Base.reduced_index(i::IdentityUnitRange{<:IdOffsetRange}) = typeof(i)(first(i):first(i))
-for f in [:firstindex, :lastindex]
-    @eval Base.$f(r::IdOffsetRange) = $f(r.parent) .+ r.offset
+for f in [:firstindex, :lastindex, :first, :last]
+    @eval @inline Base.$f(r::IdOffsetRange) = $f(r.parent) + r.offset
 end
 
 @inline function Base.iterate(r::IdOffsetRange)
@@ -148,9 +148,6 @@ end
     return (ret[1] + r.offset, ret[2])
 end
 
-@inline Base.first(r::IdOffsetRange) = first(r.parent) + r.offset
-@inline Base.last(r::IdOffsetRange) = last(r.parent) + r.offset
-
 @propagate_inbounds Base.getindex(r::IdOffsetRange, i::Integer) = r.parent[i - r.offset] + r.offset
 @propagate_inbounds function Base.getindex(r::IdOffsetRange, s::AbstractUnitRange{<:Integer})
     return r.parent[s .- r.offset] .+ r.offset