Merge pull request #12 from alsam/teh/ones_zeros

Deprecate zeros(inds::UnitRange...) and similar `ones`

Author: alsam

src/OffsetArrays.jl

@@ -111,10 +111,6 @@ end
 
 ### Convenience functions ###
 
-Base.zeros(T::Type, inds::UnitRange...) = fill!(OffsetArray{T}(inds), zero(T))
-Base.zeros(inds::UnitRange...) = zeros(Float64, inds...)
-Base.ones(T::Type, inds::UnitRange...) = fill!(OffsetArray{T}(inds), one(T))
-Base.ones(inds::UnitRange...) = ones(Float64, inds...)
 Base.fill(x, inds::Tuple{UnitRange,Vararg{UnitRange}}) = fill!(OffsetArray{typeof(x)}(inds), x)
 @inline Base.fill(x, ind1::UnitRange, inds::UnitRange...) = fill(x, (ind1, inds...))
 
@@ -161,4 +157,11 @@ end
 @inline unsafe_getindex(a::OffsetArray, I...) = unsafe_getindex(a, Base.IteratorsMD.flatten(I)...)
 @inline unsafe_setindex!(a::OffsetArray, val, I...) = unsafe_setindex!(a, val, Base.IteratorsMD.flatten(I)...)
 
+# Deprecations
+import Base: zeros, ones
+@deprecate zeros(T::Type, inds::UnitRange...) fill!(OffsetArray{T}(inds), zero(T))
+@deprecate  ones(T::Type, inds::UnitRange...) fill!(OffsetArray{T}(inds), one(T))
+@deprecate zeros(inds::UnitRange...) fill!(OffsetArray{Float64}(inds), 0)
+@deprecate  ones(inds::UnitRange...) fill!(OffsetArray{Float64}(inds), 1)
+
 end # module

test/runtests.jl

@@ -314,12 +314,6 @@ v = OffsetArray(rand(8), (-2,))
 @test A+A == OffsetArray(parent(A)+parent(A), A.offsets)
 @test A.*A == OffsetArray(parent(A).*parent(A), A.offsets)
 
-B = zeros(1:3, -1:1)
-@test indices(B) == (1:3,-1:1)
-@test all(B .== 0)
-B = ones(1:3, -1:1)
-@test indices(B) == (1:3,-1:1)
-@test all(B .== 1)
 B = fill(5, 1:3, -1:1)
 @test indices(B) == (1:3,-1:1)
 @test all(B.==5)