-
Notifications
You must be signed in to change notification settings - Fork 8
Replace Parameters.@with_kw with Base.@kwdef
#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
===========================================
+ Coverage 99.62% 100.00% +0.37%
===========================================
Files 10 10
Lines 267 296 +29
===========================================
+ Hits 266 296 +30
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This should be ready for review too now. Thanks! |
Parameters.@with_kw with Base.@kwdef
|
Seems fine to me, main point is to get rid of Parameters dependency? I do not use |
|
Sgtm! Right, the aim is to drop the Parameters dependency Same. The only difference I am aware of is that Parameters supports DustExtinction.jl/src/fittable_laws.jl Lines 56 to 57 in 2dad230
There seems to be some discussion about moving away from |
|
Looks good to merge |
Partially addresses #59
Experimenting with replacing
Parameters.@with_kwwithBase.@kwdef