chore: increase code coverage for AstrodynamicalCalculations (#264)

cadojo · web-flow · commit 8cd29ca107d0 · 2025-07-26T22:35:27.000Z
## Changes While code coverage is not yet near 100%, this commit adds coverage! --- Reviewer: @cadojo
diff --git a/.devcontainer/devcontainer-lock.json b/.devcontainer/devcontainer-lock.json
@@ -0,0 +1,49 @@
+{
+  "features": {
+    "ghcr.io/devcontainer-community/devcontainer-features/starship.rs:1": {
+      "version": "1.0.0",
+      "resolved": "ghcr.io/devcontainer-community/devcontainer-features/starship.rs@sha256:436765d97a663dc00b69466dca52dd7dcc073ad43c1aa25237852c291ffb2489",
+      "integrity": "sha256:436765d97a663dc00b69466dca52dd7dcc073ad43c1aa25237852c291ffb2489"
+    },
+    "ghcr.io/devcontainers-extra/features/pre-commit:2": {
+      "version": "2.0.18",
+      "resolved": "ghcr.io/devcontainers-extra/features/pre-commit@sha256:6e0bb2ce80caca1d94f44dab5d0653d88a1c00984e590adb7c6bce012d0ade6e",
+      "integrity": "sha256:6e0bb2ce80caca1d94f44dab5d0653d88a1c00984e590adb7c6bce012d0ade6e"
+    },
+    "ghcr.io/devcontainers/features/git-lfs:1": {
+      "version": "1.2.5",
+      "resolved": "ghcr.io/devcontainers/features/git-lfs@sha256:71c2b371cf12ab7fcec47cf17369c6f59156100dad9abf9e4c593049d789de72",
+      "integrity": "sha256:71c2b371cf12ab7fcec47cf17369c6f59156100dad9abf9e4c593049d789de72"
+    },
+    "ghcr.io/devcontainers/features/git:1": {
+      "version": "1.3.4",
+      "resolved": "ghcr.io/devcontainers/features/git@sha256:f24645e64ad39a596131a50ec96f7d5cf7a2a87544cce772dd4b7182a233e98a",
+      "integrity": "sha256:f24645e64ad39a596131a50ec96f7d5cf7a2a87544cce772dd4b7182a233e98a"
+    },
+    "ghcr.io/devcontainers/features/github-cli:1": {
+      "version": "1.0.14",
+      "resolved": "ghcr.io/devcontainers/features/github-cli@sha256:ca677566507c4118e4368cd76a4800807e911e5e350cc3525fb67ebc9132dfa1",
+      "integrity": "sha256:ca677566507c4118e4368cd76a4800807e911e5e350cc3525fb67ebc9132dfa1"
+    },
+    "ghcr.io/devcontainers/features/python:1": {
+      "version": "1.7.1",
+      "resolved": "ghcr.io/devcontainers/features/python@sha256:cf9b6d879790a594b459845b207c5e1762a0c8f954bb8033ff396e497f9c301b",
+      "integrity": "sha256:cf9b6d879790a594b459845b207c5e1762a0c8f954bb8033ff396e497f9c301b"
+    },
+    "ghcr.io/julialang/devcontainer-features/julia:1": {
+      "version": "1.2.0",
+      "resolved": "ghcr.io/julialang/devcontainer-features/julia@sha256:748ff7272e392e0c2ac7c837dbdc6c8cfa1dd3f81819fd29a111c718e3c4199d",
+      "integrity": "sha256:748ff7272e392e0c2ac7c837dbdc6c8cfa1dd3f81819fd29a111c718e3c4199d"
+    },
+    "ghcr.io/rocker-org/devcontainer-features/apt-packages:1": {
+      "version": "1.0.2",
+      "resolved": "ghcr.io/rocker-org/devcontainer-features/apt-packages@sha256:87a4d7750a596a5db034ba8508782f31aebdc2ffe955c66aaecb33d9de2ecdae",
+      "integrity": "sha256:87a4d7750a596a5db034ba8508782f31aebdc2ffe955c66aaecb33d9de2ecdae"
+    },
+    "ghcr.io/rocker-org/devcontainer-features/quarto-cli:1": {
+      "version": "1.1.4",
+      "resolved": "ghcr.io/rocker-org/devcontainer-features/quarto-cli@sha256:74960cb27e2be0dbea52c666342fd4eb69475cec971440265b3944eee30e1f86",
+      "integrity": "sha256:74960cb27e2be0dbea52c666342fd4eb69475cec971440265b3944eee30e1f86"
+    }
+  }
+}
diff --git a/README.md b/README.md
@@ -46,7 +46,7 @@ trajectory = propagate(orbit, orbital_period(orbit))
 
 furnsh(
     de440s(),                   # position and velocity data for nearby planets
-    latest_leapseconds_lsk(),   # timekeeping, parsing epochs
+    latest_leapseconds_tls(),   # timekeeping, parsing epochs
     gm_de440(),                 # mass parameters for major solar system bodies
     pck00011(),                 # physical properties of major solar system bodies
 )
diff --git a/lib/AstrodynamicalCalculations/LICENSE b/lib/AstrodynamicalCalculations/LICENSE
diff --git a/lib/AstrodynamicalCalculations/README.md b/lib/AstrodynamicalCalculations/README.md
@@ -1,6 +1,3 @@
-[![Tests](https://github.com/cadojo/AstrodynamicalCalculations.jl/workflows/Tests/badge.svg)](https://github.com/cadojo/AstrodynamicalCalculations.jl/actions?query=workflow%3ATests)
-[![Docs](https://github.com/cadojo/AstrodynamicalCalculations.jl/workflows/Documentation/badge.svg)](https://cadojo.github.io/AstrodynamicalCalculations.jl)
-
 # `AstrodynamicalCalculations.jl`
 
 _Common calculations relating to orbital mechanics and astrodynamics._
@@ -23,7 +20,7 @@ also provided.
 Two newer Lambert solver implementations (Lancaster / Blanchard, and
 Oldenhuis) are also provided, but they are currently not working. Something seems to have
 not transferred well while porting the code from MATLAB to Julia. I hope to work on this
-more in 2024.
+more in 2026.
 
 ## Getting Stated
 
diff --git a/lib/AstrodynamicalCalculations/src/R2BPCalculations.jl b/lib/AstrodynamicalCalculations/src/R2BPCalculations.jl
@@ -226,7 +226,8 @@ Returns semimajor axis parameter, a.
 """
 semimajor_axis(r::Number, v::Number, μ) = inv((2 / r) - (v^2 / μ))
 semimajor_axis(r, v, μ) = semimajor_axis(norm(r), norm(v), μ)
-semimajor_axis(x, y, z, ẋ, ẏ, ż, μ) = semimajor_axis((x, y, z), (ẋ, ẏ, ż), μ)
+semimajor_axis(x, y, z, ẋ, ẏ, ż, μ) =
+    semimajor_axis(SVector(x, y, z), SVector(ẋ, ẏ, ż), μ)
 
 """
 Returns the orbital inclination.
@@ -272,7 +273,7 @@ Returns specific orbital energy, ϵ.
 specific_energy(a, μ) = (-μ / (2 * a))
 specific_energy(r, v, μ) = (v^2 / 2) - (μ / r)
 specific_energy(x, y, z, ẋ, ẏ, ż, μ) =
-    specific_energy(norm((x, y, z)), norm((ẋ, ẏ, ż)), μ)
+    specific_energy(norm(SVector(x, y, z)), norm(SVector(ẋ, ẏ, ż)), μ)
 
 """
 Returns C3 value.
@@ -291,7 +292,7 @@ Returns the specific potential energy: the energy per unit mass.
 """
 specific_potential_energy(r, μ) = (μ / r)
 specific_potential_energy(x, y, z, ẋ, ẏ, ż, μ) =
-    specific_potential_energy(norm((x, y, z)), μ)
+    specific_potential_energy(norm(SVector(x, y, z)), μ)
 specific_potential_energy(r, μ, R, J₂, ϕ) =
     (μ / r) * (1 - J₂ * (R / r)^2 * ((3 / 2) * (sin(ϕ))^2 - (1 / 2)))
 
@@ -301,7 +302,7 @@ Returns orbital eccentricity vector e̅.
 function eccentricity_vector(x, y, z, ẋ, ẏ, ż, μ)
     h₁, h₂, h₃ = specific_angular_momentum_vector(x, y, z, ẋ, ẏ, ż)
     return (1 / μ) *
-           (_cross(ẋ, ẏ, ż, h₁, h₂, h₃) - μ * SVector(x, y, z) / norm((x, y, z)))
+           (_cross(ẋ, ẏ, ż, h₁, h₂, h₃) - μ * SVector(x, y, z) / norm(SVector(x, y, z)))
 
 end
 
@@ -333,8 +334,8 @@ orbital_radius(x, y, z, ẋ, ẏ, ż, μ) = orbital_radius(
 Returns the instantaneous velocity, v, for any orbital representation.
 """
 function orbital_speed(x, y, z, ẋ, ẏ, ż, μ)
-    r = norm((x, y, z))
-    v = norm((ẋ, ẏ, ż))
+    r = norm(SVector(x, y, z))
+    v = norm(SVector(ẋ, ẏ, ż))
     return orbital_speed(r, semimajor_axis(r, v, μ), μ)
 end
 
@@ -370,7 +371,7 @@ orbital_period(x, y, z, ẋ, ẏ, ż, μ) =
 Returns true anomaly, ν.
 """
 function true_anomaly(x, y, z, ẋ, ẏ, ż, μ)
-    r = (x, y, z)
+    r = norm(SVector(x, y, z))
 
     e = eccentricity(x, y, z, ẋ, ẏ, ż, μ)
     h = specific_angular_momentum(x, y, z, ẋ, ẏ, ż)
diff --git a/lib/AstrodynamicalCalculations/test/runtests.jl b/lib/AstrodynamicalCalculations/test/runtests.jl
@@ -3,9 +3,176 @@ Restricted Two-body Model tests.
 """
 module AstrodynamicalCalculationsTests
 
+using LinearAlgebra
 using Test, AstrodynamicalCalculations
 using StaticArrays
 
+@testset verbose = false "R2BP Calculations" begin
+    @test conic(0) == :Circular
+    @test conic(1) == :Parabolic
+    @test conic(0.999999) == :Elliptical
+    @test conic(1.000001) == :Hyperbolic
+
+    @test cartesian_to_perifocal(
+        0.9000000000000004,
+        100000.00000000055,
+        2.2442063995416452,
+        1.1139736859596856,
+        5.964076767085505,
+        0.786172648028967,
+        4.140536323401264,
+        -2.892055315559945,
+        6.2566039442009,
+    ) == (
+        x = -1.8727989006070282,
+        y = 2.645561295501541,
+        z = 5.188722983436087,
+        ẋ = 7.80864012260457,
+        ẏ = -0.8041738032535248,
+        ż = 1.7411380870180566,
+    )
+
+    @test semimajor_axis(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+        398600.4355070226,
+    ) == 3.060489599980775
+
+    @test inclination(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+        398600.4355070226,
+    ) == 1.976005846038532
+
+    @test right_ascension_ascending_node(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+        398600.4355070226,
+    ) == 2.943683444332231
+
+    @test argument_of_periapsis(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+        398600.4355070226,
+    ) == 4.316849536012919
+
+    @test specific_angular_momentum_vector(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+        398600.4355070226,
+    ) == specific_angular_momentum_vector(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+    )
+
+    @test specific_angular_momentum(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+    ) == norm(
+        specific_angular_momentum_vector(
+            -1.8727989006070282,
+            2.645561295501541,
+            5.188722983436087,
+            7.80864012260457,
+            -0.8041738032535248,
+            1.7411380870180566,
+        ),
+    )
+
+    @test specific_angular_momentum(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+        398600.4355070226,
+    ) == specific_angular_momentum(
+        -1.8727989006070282,
+        2.645561295501541,
+        5.188722983436087,
+        7.80864012260457,
+        -0.8041738032535248,
+        1.7411380870180566,
+    )
+
+    @test specific_energy(100000.00000000055, 398600.4355070226) == -1.993002177535102
+    @test specific_angular_momentum_vector(
+        7501.390893889291,
+        7868.393278511291,
+        4087.9520744171814,
+        4.140536323401264,
+        -2.892055315559945,
+        6.2566039442009,
+        398600.4355070226,
+    ) == specific_angular_momentum_vector(
+        7501.390893889291,
+        7868.393278511291,
+        4087.9520744171814,
+        4.140536323401264,
+        -2.892055315559945,
+        6.2566039442009,
+    )
+
+    @test specific_angular_momentum(
+        7501.390893889291,
+        7868.393278511291,
+        4087.9520744171814,
+        4.140536323401264,
+        -2.892055315559945,
+        6.2566039442009,
+        398600.4355070226,
+    ) == norm(
+        specific_angular_momentum_vector(
+            7501.390893889291,
+            7868.393278511291,
+            4087.9520744171814,
+            4.140536323401264,
+            -2.892055315559945,
+            6.2566039442009,
+        ),
+    )
+
+    @test orbital_radius(
+        7501.390893889291,
+        7868.393278511291,
+        4087.9520744171814,
+        4.140536323401264,
+        -2.892055315559945,
+        6.2566039442009,
+        398600.4355070226,
+    ) == 11279.041186710254
+
+end
+
 @testset verbose = false "R2BP Determination" begin
     r = [0.0, 11681.0, 0.0]
     v = [5.134, 4.226, 2.787]
diff --git a/lib/AstrodynamicalModels/README.md b/lib/AstrodynamicalModels/README.md
@@ -1,6 +1,3 @@
-[![Tests](https://github.com/cadojo/AstrodynamicalModels.jl/workflows/UnitTests/badge.svg)](https://github.com/cadojo/AstrodynamicalModels.jl/actions?query=workflow%3AUnitTests)
-[![Docs](https://github.com/cadojo/AstrodynamicalModels.jl/workflows/Documentation/badge.svg)](https://cadojo.github.io/AstrodynamicalModels.jl)
-
 # AstrodynamicalModels.jl
 
 _An extension of
diff --git a/lib/AstrodynamicalModels/ext/AstrodynamicalCalculationsExt.jl b/lib/AstrodynamicalModels/ext/AstrodynamicalCalculationsExt.jl
@@ -15,6 +15,8 @@ function AC.keplerian_to_cartesian(state::KeplerianState, μ)
 end
 AC.keplerian_to_cartesian(orbit::CartesianOrbit) =
     Orbit(AC.keplerian_to_cartesian(orbit.state, orbit.parameters), orbit.parameters)
+AC.keplerian_to_cartesian(orbit::KeplerianOrbit) =
+    Orbit(AC.keplerian_to_cartesian(orbit.state, orbit.parameters), orbit.parameters)
 
 function AC.cartesian_to_keplerian(state::CartesianState, μ)
     p = μ isa Number ? R2BParameters(μ) : μ
diff --git a/lib/AstrodynamicalSolvers/LICENSE b/lib/AstrodynamicalSolvers/LICENSE
diff --git a/lib/AstrodynamicalSolvers/README.md b/lib/AstrodynamicalSolvers/README.md
@@ -1,6 +1,3 @@
-[![Tests](https://github.com/cadojo/AstrodynamicalSolvers.jl/workflows/Tests/badge.svg)](https://github.com/cadojo/AstrodynamicalSolvers.jl/actions?query=workflow%3ATests)
-[![Docs](https://github.com/cadojo/AstrodynamicalSolvers.jl/workflows/Documentation/badge.svg)](https://cadojo.github.io/AstrodynamicalSolvers.jl)
-
 # `AstrodynamicalSolvers.jl`
 
 _Common solvers relating to orbital mechanics and astrodynamics._

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ trajectory = propagate(orbit, orbital_period(orbit))`
`46`	`46`
`47`	`47`	`furnsh(`
`48`	`48`	`de440s(), # position and velocity data for nearby planets`
`49`		`- latest_leapseconds_lsk(), # timekeeping, parsing epochs`
	`49`	`+ latest_leapseconds_tls(), # timekeeping, parsing epochs`
`50`	`50`	`gm_de440(), # mass parameters for major solar system bodies`
`51`	`51`	`pck00011(), # physical properties of major solar system bodies`
`52`	`52`	`)`