Merge branch 'master' of https://github.com/juliaastro/PSFKernels.jl into master

Author: mileslucas

.github/workflows/register.yml

@@ -0,0 +1,14 @@
+name: Register Package
+on:
+  workflow_dispatch:
+    inputs:
+      version:
+        description: Version to register or component to bump
+        required: true
+jobs:
+  register:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: julia-actions/RegisterAction@latest
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}

Project.toml

@@ -1,7 +1,7 @@
 name = "PSFModels"
 uuid = "9ba017d1-7760-46cd-84a3-1e79e9ae9ddc"
 authors = ["Miles Lucas <[email protected]> and contributors"]
-version = "0.1.1"
+version = "0.1.2"
 
 [deps]
 CoordinateTransformations = "150eb455-5306-5404-9cee-2592286d6298"

src/PSFModels.jl

@@ -170,18 +170,13 @@ Base.getindex(model::PSFModel, idx::Vararg{<:Number,2}) = model(reverse(idx))
 Broadcast.combine_axes(kern::PSFModel, other) = axes(other)
 Broadcast.combine_axes(other, kern::PSFModel) = axes(other)
 
-function indices_from_extent(pos, fwhm, maxsize)
-    halfextent = @. maxsize * fwhm / 2
-    lower = @. floor(Int, pos - halfextent)
-    upper = @. ceil(Int, pos + halfextent)
-    return (first(lower):first(upper), last(lower):last(upper))
-end
+indices_from_extent(pos, fwhm, maxsize) = indices_from_extent(pos, maxsize .* fwhm)
 
 function indices_from_extent(pos, extent)
     halfextent = @. extent / 2
     lower = @. round(Int, pos - halfextent)
     upper = @. round(Int, pos + halfextent)
-    return (first(lower):first(upper), last(lower):last(upper))
+    return last(lower):last(upper), first(lower):first(upper)
 end
 
 # TODO

test/runtests.jl

@@ -24,22 +24,22 @@ function test_model_interface(K)
     m = K(12, 13, 10)
     @test m == K((12, 13), 10) == K(SA[12, 13], 10)
     @test size(m) == (31, 31)
-    @test axes(m) == (-3:27, -2:28)
+    @test axes(m) == (-2:28, -3:27)
     @test m.pos ≈ SA[12, 13]
     @test eltype(m) == Float64
 
     # test diagonal fwhm
     m = K((10, 9))
     @test m == K((10, 9)) == K(SA[10, 9])
-    @test size(m) == (31, 29)
-    @test axes(m) == (-15:15, -14:14)
+    @test size(m) == (29, 31)
+    @test axes(m) == (-14:14, -15:15)
     @test m.pos ≈ SA[0, 0]
     @test eltype(m) == Float64
 
     # test different maxsize
     m = K((10, 9); maxsize=2)
-    @test size(m) == (21, 19)
-    @test axes(m) == (-10:10, -9:9)
+    @test size(m) == (19, 21)
+    @test axes(m) == (-9:9, -10:10)
     @test m.pos ≈ SA[0, 0]
     @test eltype(m) == Float64
 
@@ -113,4 +113,4 @@ end
     wdist = (1/5)^2 + (2/4.5)^2
     expected = inv(1 + wdist)
     @test m[2, 1] ≈ m(1, 2) ≈ expected
-end
+end