Skip to content

Commit 56fbeae

Browse files
committed
remove _center_angle
1 parent 17fdff6 commit 56fbeae

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

src/projected.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Base.isapprox(a::ProjectedCoords, b::ProjectedCoords; kwargs...) = isapprox(orig
2323

2424
function project(origin::AbstractSkyCoords, c::AbstractSkyCoords)
2525
cc = convert(typeof(origin), c)
26-
Δlon = _center_angle(lon(cc) - lon(origin))
26+
Δlon = rem2pi(lon(cc) - lon(origin), RoundNearest)
2727
offset = SVector(Δlon * cos(lat(origin)), lat(cc) - lat(origin))
2828
ProjectedCoords(origin, offset)
2929
end

src/types.jl

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,15 @@ function Base.convert(::Type{T}, c::S) where {T<:AbstractSkyCoords,S<:AbstractSk
8282
end
8383

8484
Base.:(==)(a::T, b::T) where {T<:AbstractSkyCoords} = lon(a) == lon(b) && lat(a) == lat(b)
85-
Base.isapprox(a::ICRSCoords, b::ICRSCoords; kwargs...) = isapprox(SVector(lon(a), lat(a)), SVector(_center_angle(lon(b) - lon(a)) + lon(a), lat(b)); kwargs...)
86-
Base.isapprox(a::GalCoords, b::GalCoords; kwargs...) = isapprox(SVector(lon(a), lat(a)), SVector(_center_angle(lon(b) - lon(a)) + lon(a), lat(b)); kwargs...)
87-
Base.isapprox(a::FK5Coords{e}, b::FK5Coords{e}; kwargs...) where {e} = isapprox(SVector(lon(a), lat(a)), SVector(_center_angle(lon(b) - lon(a)) + lon(a), lat(b)); kwargs...)
88-
89-
_center_angle(x) = mod2pi(x + π) - π
85+
Base.isapprox(a::ICRSCoords, b::ICRSCoords; kwargs...) = isapprox(
86+
SVector(lon(a), lat(a)),
87+
SVector(lon(a) + rem2pi(lon(b) - lon(a), RoundNearest), lat(b));
88+
kwargs...)
89+
Base.isapprox(a::GalCoords, b::GalCoords; kwargs...) = isapprox(
90+
SVector(lon(a), lat(a)),
91+
SVector(lon(a) + rem2pi(lon(b) - lon(a), RoundNearest), lat(b));
92+
kwargs...)
93+
Base.isapprox(a::FK5Coords{e}, b::FK5Coords{e}; kwargs...) where {e} = isapprox(
94+
SVector(lon(a), lat(a)),
95+
SVector(lon(a) + rem2pi(lon(b) - lon(a), RoundNearest), lat(b));
96+
kwargs...)

0 commit comments

Comments
 (0)