Merge pull request #11 from JuliaAstro/update-docs-and-improvements

Update docs

Author: langestefan

docs/src/contributing.md

@@ -9,14 +9,18 @@ Be polite and respectful.
 ## Bug reports and discussions
 
 If you think you found a bug, feel free to open an [issue](https://github.com/JuliaAstro/SolarPosition.jl/issues).
+
 Focused suggestions and requests can also be opened as issues.
-Before opening a pull request, start an issue or a discussion on the topic, please.
+
+!!! info
+    Before opening a pull request, it can be productive to first start an issue or a
+    discussion on the topic so that the maintainers and community can provide feedback.
 
 ## Working on an issue
 
-If you found an issue that interests you, comment on that issue what your plans are.
-If the solution to the issue is clear, you can immediately create a pull request (see below).
-Otherwise, say what your proposed solution is and wait for a discussion around it.
+If you found an issue that interests you, comment on that issue what your plans are. If
+the solution to the issue is clear, you can immediately create a pull request (see below
+). Otherwise, say what your proposed solution is and wait for a discussion around it.
 
 !!! tip
     Feel free to ping us after a few days if there are no responses.

docs/src/index.md

@@ -6,7 +6,6 @@ CurrentModule = SolarPosition
 
 ## SolarPosition.jl
 
-[![Development documentation](https://img.shields.io/badge/docs-dev-blue.svg)](https://juliaastro.org/SolarPosition.jl/dev/)
 [![Test workflow status](https://github.com/JuliaAstro/SolarPosition.jl/actions/workflows/Test.yml/badge.svg?branch=main)](https://github.com/JuliaAstro/SolarPosition.jl/actions/workflows/Test.yml?query=branch%3Amain)
 [![Coverage](https://codecov.io/gh/JuliaAstro/SolarPosition.jl/branch/main/graph/badge.svg)](https://codecov.io/gh/JuliaAstro/SolarPosition.jl)
 [![Lint workflow Status](https://github.com/JuliaAstro/SolarPosition.jl/actions/workflows/Lint.yml/badge.svg?branch=main)](https://github.com/JuliaAstro/SolarPosition.jl/actions/workflows/Lint.yml?query=branch%3Amain)

src/Positioning/Positioning.jl

@@ -22,7 +22,7 @@ refraction corrections.
 module Positioning
 
 using Dates: datetime2julian, DateTime, Date, daysinmonth, dayofyear
-using Dates: year, month, day, hour, minute, second
+using Dates: year, month, day, hour, minute, second, millisecond
 using TimeZones: ZonedDateTime, UTC
 using StructArrays: StructArrays
 using Tables: Tables

src/Positioning/utils.jl

@@ -1,14 +1,12 @@
 """Utility functions to be used across solar positioning algorithms."""
 
-# wrap angle to [-π, π]
-@inline wrapπ(x::T) where {T} = ifelse(x > π, x - 2π, ifelse(x < -π, x + 2π, x))
-
 # degree helpers
 deg2rad(x::Real) = float(x) * (π / 180)
 rad2deg(x::Real) = float(x) * (180 / π)
 
 # fractional hour helper
-fractional_hour(dt::DateTime) = hour(dt) + minute(dt) / 60 + second(dt) / 3600
+fractional_hour(dt::DateTime) =
+    (hour(dt) + minute(dt) / 60.0 + second(dt) / 3600.0 + millisecond(dt) / 3.6e6)
 
 # constants
 const EMR = 6371.01  # Earth Mean Radius in km