Merge pull request #39 from JuliaAstro/tolerance

Reduce tolerance for all tests to 1e-8

Author: langestefan

test/test-iqbal.jl

@@ -49,9 +49,9 @@ end
         #     end
         #
         #     res = solar_position(obs, dt, Iqbal())
-        #     @test isapprox(res.elevation, exp_elev, atol = 1e-6)
-        #     @test isapprox(res.zenith, exp_zen, atol = 1e-6)
-        #     @test isapprox(res.azimuth, exp_az, atol = 1e-6)
+        #     @test isapprox(res.elevation, exp_elev, atol = 1e-8)
+        #     @test isapprox(res.zenith, exp_zen, atol = 1e-8)
+        #     @test isapprox(res.azimuth, exp_az, atol = 1e-8)
         # end
     end
 end

test/test-mtk.jl

@@ -87,7 +87,7 @@ using CairoMakie
         @test length(zenith_vals) == length(sol.t)
 
         # Check that zenith ≈ 90 - elevation
-        @test all(isapprox.(zenith_vals, 90 .- elevation_vals; atol = 1e-6))
+        @test all(isapprox.(zenith_vals, 90 .- elevation_vals; atol = 1e-8))
 
         # For summer solstice in San Francisco, check that:
         # 1. The sun rises (elevation goes from negative to positive)
@@ -201,14 +201,14 @@ using CairoMakie
                     @test isapprox(
                         sol[sys.elevation][1],
                         row.apparent_elevation,
-                        atol = 1e-6,
+                        atol = 1e-8,
                     )
-                    @test isapprox(sol[sys.zenith][1], row.apparent_zenith, atol = 1e-6)
+                    @test isapprox(sol[sys.zenith][1], row.apparent_zenith, atol = 1e-8)
                 else
-                    @test isapprox(sol[sys.elevation][1], row.elevation, atol = 1e-6)
-                    @test isapprox(sol[sys.zenith][1], row.zenith, atol = 1e-6)
+                    @test isapprox(sol[sys.elevation][1], row.elevation, atol = 1e-8)
+                    @test isapprox(sol[sys.zenith][1], row.zenith, atol = 1e-8)
                 end
-                @test isapprox(sol[sys.azimuth][1], row.azimuth, atol = 1e-6)
+                @test isapprox(sol[sys.azimuth][1], row.azimuth, atol = 1e-8)
             end
         end
     end

test/test-noaa.jl

@@ -28,11 +28,11 @@
             res = solar_position(obs, dt, NOAA(), HUGHES(101325.0, 10.0))
 
             # azimuth calculations have small variations
-            @test isapprox(res.elevation, exp_elev, atol = 2e-7)
-            @test isapprox(res.zenith, exp_zen, atol = 2e-7)
-            @test isapprox(res.azimuth, exp_az, atol = 3e-7)
-            @test isapprox(res.apparent_elevation, exp_app_elev, atol = 2e-7)
-            @test isapprox(res.apparent_zenith, exp_app_zen, atol = 2e-7)
+            @test isapprox(res.elevation, exp_elev, atol = 1e-8)
+            @test isapprox(res.zenith, exp_zen, atol = 1e-8)
+            @test isapprox(res.azimuth, exp_az, atol = 1e-8)
+            @test isapprox(res.apparent_elevation, exp_app_elev, atol = 1e-8)
+            @test isapprox(res.apparent_zenith, exp_app_zen, atol = 1e-8)
         end
     end
 

test/test-psa.jl

@@ -22,9 +22,9 @@
             end
 
             res = solar_position(obs, dt, PSA(i))
-            @test isapprox(res.elevation, exp_elev, atol = 1e-6)
-            @test isapprox(res.zenith, exp_zen, atol = 1e-6)
-            @test isapprox(res.azimuth, exp_az, atol = 1e-6)
+            @test isapprox(res.elevation, exp_elev, atol = 1e-8)
+            @test isapprox(res.zenith, exp_zen, atol = 1e-8)
+            @test isapprox(res.azimuth, exp_az, atol = 1e-8)
         end
     end
 

test/test-refraction.jl

@@ -88,14 +88,14 @@ elevations = test_elevation_angles()
     @testset "Scalar computation" begin
         for (i, elev) in enumerate(elevations)
             result = refraction(algorithm, elev)
-            @test result ≈ expected[i] atol = 1e-7
+            @test result ≈ expected[i] atol = 1e-8
         end
     end
 
     @testset "Vectorized computation" begin
         results = refraction.(Ref(algorithm), elevations)
         for (i, res) in enumerate(results)
-            @test res ≈ expected[i] atol = 1e-7
+            @test res ≈ expected[i] atol = 1e-8
         end
     end
 end

test/test-spa.jl

@@ -19,12 +19,12 @@
             # SPA includes refraction correction and equation of time
             res = solar_position(obs, dt, SPA())
 
-            @test isapprox(res.elevation, row.elevation, atol = 1e-6)
-            @test isapprox(res.zenith, row.zenith, atol = 1e-6)
-            @test isapprox(res.azimuth, row.azimuth, atol = 1e-6)
-            @test isapprox(res.apparent_elevation, row.apparent_elevation, atol = 1e-6)
-            @test isapprox(res.apparent_zenith, row.apparent_zenith, atol = 1e-6)
-            @test isapprox(res.equation_of_time, row.equation_of_time, atol = 1e-6)
+            @test isapprox(res.elevation, row.elevation, atol = 1e-8)
+            @test isapprox(res.zenith, row.zenith, atol = 1e-8)
+            @test isapprox(res.azimuth, row.azimuth, atol = 1e-8)
+            @test isapprox(res.apparent_elevation, row.apparent_elevation, atol = 1e-8)
+            @test isapprox(res.apparent_zenith, row.apparent_zenith, atol = 1e-8)
+            @test isapprox(res.equation_of_time, row.equation_of_time, atol = 1e-8)
         end
     end
 
@@ -67,7 +67,7 @@
         @test !isapprox(
             res_default.apparent_elevation,
             res_custom.apparent_elevation,
-            atol = 1e-6,
+            atol = 1e-8,
         )
 
         @test isapprox(res_default.elevation, res_custom.elevation, atol = 1e-10)

test/test-usno.jl

@@ -19,9 +19,9 @@
 
             res = solar_position(obs, dt, USNO())
 
-            @test isapprox(res.elevation, exp_elev, atol = 1e-6)
-            @test isapprox(res.zenith, exp_zen, atol = 1e-6)
-            @test isapprox(res.azimuth, exp_az, atol = 1e-6)
+            @test isapprox(res.elevation, exp_elev, atol = 1e-8)
+            @test isapprox(res.zenith, exp_zen, atol = 1e-8)
+            @test isapprox(res.azimuth, exp_az, atol = 1e-8)
         end
     end
 
@@ -39,9 +39,9 @@
 
             res = solar_position(obs, dt, USNO(67.0, 2))
 
-            @test isapprox(res.elevation, exp_elev, atol = 1e-6)
-            @test isapprox(res.zenith, exp_zen, atol = 1e-6)
-            @test isapprox(res.azimuth, exp_az, atol = 1e-6)
+            @test isapprox(res.elevation, exp_elev, atol = 1e-8)
+            @test isapprox(res.zenith, exp_zen, atol = 1e-8)
+            @test isapprox(res.azimuth, exp_az, atol = 1e-8)
         end
     end
 

test/test-walraven.jl

@@ -17,9 +17,9 @@
         end
 
         res = solar_position(obs, dt, Walraven())
-        @test isapprox(res.elevation, exp_elev, atol = 1e-6)
-        @test isapprox(res.zenith, exp_zen, atol = 1e-6)
-        @test isapprox(res.azimuth, exp_az, atol = 1e-6)
+        @test isapprox(res.elevation, exp_elev, atol = 1e-8)
+        @test isapprox(res.zenith, exp_zen, atol = 1e-8)
+        @test isapprox(res.azimuth, exp_az, atol = 1e-8)
     end
 
     @testset "Walraven edge cases" begin