removed every mention of angstrom, fixes issue #14 (#15)

* removed every mention of angstrom as it is now redundant, fixes issue #14

* reverted changes to NEWS.md and tests, bumped compat version of Unitful to 0.18.0

* fixed test by including base Unitful

* Unitful angstrom is implemented as a rational number type multiplied by the nanometer, so we should write tests with the rational number type

* promotion to Float64 in angstrom test

* Use uppor bounds in compat section

* Use isapprox for angstrom test

* Restore other test

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Author: Zack Li

Project.toml

@@ -8,8 +8,8 @@ Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
 UnitfulAngles = "6fb2a4bd-7999-5318-a3b2-8ad61056cd98"
 
 [compat]
-Unitful = "≥ 0.17.0"
-julia = "≥ 1.0.0"
+Unitful = "0.18.0"
+julia = "1.0.0"
 
 [extras]
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

README.md

@@ -25,7 +25,6 @@ The list of additional units is given below:
 * [Light year](https://en.wikipedia.org/wiki/Light-year)
 * [Parsec](https://en.wikipedia.org/wiki/Parsec)
 * [Jansky](https://en.wikipedia.org/wiki/Jansky)
-* [Angstrom](https://en.wikipedia.org/wiki/%C3%85ngstr%C3%B6m)
 * [Solar radius](https://en.wikipedia.org/wiki/Solar_radius)
 * [Solar irradiance](https://en.wikipedia.org/wiki/Solar_irradiance)
 * [Solar luminosity](https://en.wikipedia.org/wiki/Solar_luminosity)

appveyor.yml

@@ -1,6 +1,6 @@
 environment:
   matrix:
-  - julia_version: 1
+  - julia_version: 1.0
   - julia_version: 1.1
   - julia_version: 1.2
   - julia_version: nightly

docs/generate-table-entries.jl

@@ -11,7 +11,6 @@ table = (("Erg", :erg, :J),
          ("Light year", :ly, :cm),
          ("Parsec", :pc, :cm),
          ("Jansky", :Jy, u"erg/s/cm^2/Hz"),
-         ("Angstrom", :angstrom, :nm),
          ("Solar radius", :Rsun, :cm),
          ("Solar irradiance", :Ssun, u"erg/s/cm^2"),
          ("Solar luminosity", :Lsun, u"erg/s"),

docs/src/index.md

@@ -18,7 +18,6 @@ The list of additional units is given below:
 |                  Light year |        `UnitfulAstro.ly` |        `9.4607304725808e17 cm` |
 |                      Parsec |        `UnitfulAstro.pc` |     `3.0856775814913674e18 cm` |
 |                      Jansky |        `UnitfulAstro.Jy` | `1.0e-23 erg Hz^-1 cm^-2 s^-1` |
-|                    Angstrom |  `UnitfulAstro.angstrom` |                       `0.1 nm` |
 |                Solar radius |      `UnitfulAstro.Rsun` |                  `6.957e10 cm` |
 |            Solar irradiance |      `UnitfulAstro.Ssun` |       `1.361e6 erg cm^-2 s^-1` |
 |            Solar luminosity |      `UnitfulAstro.Lsun` |            `3.828e33 erg s^-1` |

src/UnitfulAstro.jl

@@ -52,7 +52,6 @@ import UnitfulAngles: arcminute, arcsecond
 # Note that IAU 2015 defines the small angle approximation as exact in the definition of the parsec.
 @unit Jy         "Jy"       Jansky                    1e-23erg*s^-1*cm^-2*Hz^-1 true
 # Note that Jy uses a Float64 conversion factor because 10^23 overflows Int64.
-@unit angstrom   "Å"        Angstrom                  1e-10*m                   false
 
 # SOLAR CONVERSION CONSTANTS (IAU 2015)
 @unit Rsun       "R⊙"       SolarRadius               6.957e8*m                 false

test/runtests.jl

@@ -1,3 +1,4 @@
+using Unitful
 using UnitfulAstro
 using Test
 
@@ -13,7 +14,7 @@ const u = UnitfulAstro
         @test 365.25*u.d == 1*u.yr
         @test 1*u.ly == 1*u.c*u.yr
         @test 1*u.pc == 1*u.AU/u.arcsecond
-        @test 1*u.angstrom == 1e-10*u.m
+        @test 1.0*Unitful.angstrom ≈ 1e-10*u.m
         @test 1*u.SFU ≈ 10000*u.Jy
         @test 1*u.TECU == 1e12*u.cm^-2
     end
@@ -69,8 +70,8 @@ const u = UnitfulAstro
         @test isapprox(flux * mag, 3.981071705534972u.erg/u.s)
         flux = 10u.erg/u.s/u.cm^2
         @test isapprox(flux * mag, 3.981071705534972u.erg/u.s/u.cm^2)
-        flux = 10u.erg/u.s/u.cm^2/u.angstrom
-        @test isapprox(flux * mag, 3.981071705534972u.erg/u.s/u.cm^2/u.angstrom)
+        flux = 10u.erg/u.s/u.cm^2/Unitful.angstrom
+        @test isapprox(flux * mag, 3.981071705534972u.erg/u.s/u.cm^2/Unitful.angstrom)
     end
 end