Fix mis-bundling with tar

Also, increase lower limit in tests, now that I realize that I had bad corefiles

Author: staticfloat

.buildkite/pipeline.yml

@@ -227,23 +227,23 @@ steps:
 
       echo "+++ Run coredump checks"
 
-      # Ensure that all files are above 5k (e.g. not empty tar/zstd streams)
+      # Ensure that all files are above 20k (e.g. not empty tar/zstd streams)
       for f in *.core*; do
-        echo -n "Check that $${f} is > 5kb: "
-        (( "$$(stat -c%s "$${f}")" > 5120 ))
+        echo -n "Check that $${f} is > 20kb: "
+        (( "$$(stat -c%s "$${f}")" > 20480 ))
         echo "✔️"
       done
 
-      echo -n "Seven corefiles overall: "
-      [[ "$$(ls *.core* | wc -l)" == "7" ]]
+      echo -n "Eight corefiles overall: "
+      [[ "$$(ls *.core* | wc -l)" == "8" ]]
       echo "✔️"
 
       echo -n "Three zstd julia corefiles: "
       [[ "$$(ls julia-*.core.zst | wc -l)" == "3" ]]
       echo "✔️"
 
-      echo -n "One raw bash corefile: "
-      [[ "$$(ls bash-*.core | wc -l)" == "1" ]]
+      echo -n "Two raw bash corefile: "
+      [[ "$$(ls bash-*.core | wc -l)" == "2" ]]
       echo "✔️"
       
       echo -n "One raw bash bundled bash corefile: "

lib/compression.sh

@@ -26,15 +26,20 @@ function compressed_bundle_names() {
 
 function compress_bundle() {
     local COREFILE="${1}"
+    local BUNDLE_NAME="$(compressed_bundle_names "${COREFILE}")"
+
+    # Skip out early if we're not doing anything
+    if [[ "${COREFILE}" == "${BUNDLE_NAME}" ]]; then
+        return
+    fi
 
-    # We are going to use `tar` to bundle together one or more files:
-    declare -a FILE_LIST
     if [[ "${CREATE_BUNDLE}" == "true" ]]; then
+        # Pass the file list off to `tar` and compress it
+        declare -a FILE_LIST
         readarray -t FILE_LIST < <(collect_bundle_files "${COREFILE}")
+        tar hc "${FILE_LIST[@]}" | compress > "${BUNDLE_NAME}"
     else
-        FILE_LIST=( "${COREFILE}" )
+        # Compress the file directly
+        compress <"${COREFILE}" >"${BUNDLE_NAME}"
     fi
-
-    # Pass the file list off to `tar` and compress it
-    tar hc "${FILE_LIST[@]}" | compress > "$(compressed_bundle_names "${COREFILE}")"
 }