Test with new julia LTS 1.10 #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just changed the secret usage to only store the values in github instead of the key-value-pair |
Contributor
Author
|
@juliohm can you check the secrets again? |
juliohm
reviewed
Jan 8, 2025
| matrix: | ||
| version: | ||
| - '1.6' | ||
| - '1.10' |
Member
There was a problem hiding this comment.
Suggested change
| - '1.10' | |
| - 'lts' |
juliohm
reviewed
Jan 8, 2025
Member
juliohm
left a comment
juliohm
left a comment
There was a problem hiding this comment.
The keys are in the expected format, without the prefix. I've made the LTS support explicit in the CI.yml.
Member
|
I can't propose changes in this branch of your fork, but I am assuming that CI will succeed after you accept the suggestion. |
Member
|
Tried these changes on the master branch. Let's see if they solve the issue. |
Member
|
Issue fixed on master ❤️ Thank you @maxstb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github actions are running with the new API (#46) and new secrets.
For the secrets however it's important to store it in the following way:
CDSAPI_URL = "url: https://cds.climate.copernicus.eu/api"
CDSAPI_KEY = "key: XXXXXXXXXXXXXXXXXXXXX"
I just considered that we should update the tests to the new LTS version of julia
Fix #46