Merge pull request #616 from harryscholes/fix-614

Remove deprecated deque method

Author: oxinabox

Project.toml

@@ -1,6 +1,6 @@
 name = "DataStructures"
 uuid = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
-version = "0.17.14"
+version = "0.17.15"
 
 [deps]
 InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"

src/DataStructures.jl

@@ -21,7 +21,7 @@ module DataStructures
     export complement, complement!
 
     export Deque, Stack, Queue, CircularDeque
-    export deque, enqueue!, dequeue!, dequeue_pair!, update!, reverse_iter
+    export enqueue!, dequeue!, dequeue_pair!, update!, reverse_iter
     export capacity, num_blocks, top_with_handle, sizehint!
 
     export Accumulator, counter, reset!, inc!, dec!

src/deque.jl

@@ -81,13 +81,6 @@ mutable struct Deque{T}
     Deque{T}() where {T} = Deque{T}(DEFAULT_DEQUEUE_BLOCKSIZE)
 end
 
-"""
-    deque(T)
-
-Create a deque of type `T`.
-"""
-deque(::Type{T}) where {T} = Deque{T}()
-
 isempty(q::Deque) = q.len == 0
 length(q::Deque) = q.len
 num_blocks(q::Deque) = q.nblocks

test/bench_deque.jl

@@ -11,7 +11,7 @@ function batch_pushback!(v::Container, n::Int, e::T) where {Container,T}
 end
 
 v = Int[]
-q = deque(Int)
+q = Deque{Int}()
 
 batch_pushback!(v, 10, 0)
 t1 = @elapsed batch_pushback!(v, 10^7, 0)
@@ -33,7 +33,7 @@ function batch_pushfront!(v::Container, n::Int, e::T) where {Container,T}
 end
 
 v = Int[]
-q = deque(Int)
+q = Deque{Int}()
 
 batch_pushfront!(v, 10, 0)
 t1 = @elapsed batch_pushfront!(v, 10^7, 0)

test/test_deque.jl

@@ -12,10 +12,6 @@
             @test length(sprint(dump,q)) >= 0
         end
 
-        @testset "empty dequeue 2" begin
-            @test typeof(deque(Int)) === typeof(Deque{Int}())
-        end
-
         @testset "empty dequeue 3" begin
             q = DataStructures.DequeBlock{Int}(0,0)
             @test length(q) == 0
@@ -202,4 +198,8 @@
         @test isempty(q)
     end
 
+    @testset "deprecated constructors" begin
+        @test_deprecated deque(Int)
+    end
+
 end # @testset Deque