Skip to content

Conversation

@odow
Copy link
Contributor

@odow odow commented Aug 25, 2025

This deprecation broke JuMP and a bunch of related packages that test with --depwarn=error (to avoid using deprecated bindings): jump-dev/JuMP.jl#4058

One downside to this PR is that it introduces a new (deprecated) DisjointSet(xs...) method.

There is already a test that DisjointSets(xs...) is equivalent to DisjointSet(xs...) and then DisjointSet(xs):

@test DisjointSets(1:10...) == DisjointSet(1:10)

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Looks good.
Can you bump the version number?

@odow
Copy link
Contributor Author

odow commented Aug 25, 2025

I bumped but then reverted. There's actually a few commits on master, so I'll make a separate PR that updates the version and adds release notes.

@odow odow force-pushed the od/fix-deprecation branch from 46ec63b to 4595212 Compare August 25, 2025 22:11
@odow odow mentioned this pull request Aug 25, 2025
@oxinabox oxinabox merged commit 71775aa into JuliaCollections:master Aug 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants