Skip to content

Conversation

@LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Aug 4, 2025

Partially reverts #102.

Notably, I prefer 1.0 over min because that is one extra step in the way of accidentally dropping 1.0 compat.

I'm happy to test lts and pre in addition to the existing matrix. For a high-dependent, low-chrun package, extensive CI is appropriate.

@LilithHafner LilithHafner changed the title Revert "Adjust CI Julia versions" Partially revert "Adjust CI Julia versions" Aug 4, 2025
@LilithHafner
Copy link
Member Author

AFAICT, nightly failures are due to Aqua.jl being incompatible with Julia nightly. This breaks CI on main because it reverts a commit that skipped running the broken tests. That's fine because nightly tests are informative but not required.

@LilithHafner LilithHafner merged commit c7697b9 into main Aug 4, 2025
21 of 26 checks passed
@LilithHafner LilithHafner deleted the revert-102-andreasnoack-patch-1 branch August 4, 2025 00:46
@andreasnoack
Copy link
Collaborator

You maintain so you decide but having failing CI on master just looks bad. It makes a package look poorly maintained, which is a shame when, as in this case, it isn't.

@LilithHafner
Copy link
Member Author

I weigh things actually working and accurate representation to users very highly while I weigh "good PR"/"looking like everything is working" fairly low. So I'll continue to show folks who view the README info on CI status including nightly. I agree that it would be nice to show a green badge when all required checks pass and un-required checks don't pass but it's not worth the complexity and maintenance burden to achieve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants