Skip to content

Commit 894e0dc

Browse files
committed
more fixes
1 parent a353bb1 commit 894e0dc

File tree

4 files changed

+27
-23
lines changed

4 files changed

+27
-23
lines changed

Manifest.toml

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/ddt.jl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ let sys = IRODESystem(ddt_nonlinear; debug_config=(; store_ss_levels=true))
2929

3030
for sol in solve_dae(sys, [0.], [1.], (0., 1.); reltol=1e-6)
3131
@test all(isapprox.(sol[sys.x], exp.(sol.t), atol=1e-4))
32-
@test all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-4))
32+
#DAECompiler incorrectly tries to interpolate based on algebraic vars
33+
@test_broken all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-4))
3334
end
3435

3536
for level in dbg.ss_levels
@@ -50,8 +51,11 @@ end
5051
let sys = IRODESystem(ddt_nonlinear2; debug_config=(; store_ss_levels=true))
5152
dbg = getfield(sys, :debug_config)
5253

53-
for sol in (solve_dae(sys, [0., 0.], [1., 1.], (0., 1.))...,
54-
solve_ode(sys, [1., 1., 0., 0.], (0., 1.))..., )
54+
for sol in solve_dae(sys, [0., 0.], [1., 1.], (0., 1.))
55+
@test all(isapprox.(sol[sys.x], exp.(sol.t), atol=1e-2))
56+
@test all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-2))
57+
end
58+
for sol in solve_ode(sys, [1., 1., 0., 0.], (0., 1.))
5559
@test all(isapprox.(sol[sys.x], exp.(sol.t), atol=1e-2))
5660
@test all(isapprox.(sol[sys.y], exp.(sol.t), atol=1e-2))
5761
end

test/implied_alias.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ using Test
44
using SciMLBase
55
using DAECompiler
66
using DAECompiler.Intrinsics
7-
using OrdinaryDiffEq
87

98
include("testutils.jl")
109

test/regression.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,7 @@ function (p::OneParam)()
371371
equation!(state_ddt(state_ddt(y)) - z*ẍ)
372372
equation!(x - ẍ)
373373
end
374+
using Sundails
374375
let sys = IRODESystem(Tuple{OneParam}; debug_config=(;store_ir_levels=true, store_ss_levels=true));
375376
daeprob = DAEProblem(sys, [0., 0., 0.], [1., 0., 1.], (0., 1.), OneParam(1.));
376377
sol = solve(daeprob, IDA())

0 commit comments

Comments
 (0)