Skip to content

Commit 79f9148

Browse files
committed
refactor: rename DatasetStorage -> _DatasetStorage
This is an internal type and not part of the public API.
1 parent ede4df9 commit 79f9148

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/datasets.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const _DOCS_nondynamic_datasets_object_warning = """
66
metadata, you can pass the existing [`Dataset`](@ref) to [`JuliaHub.dataset`](@ref).
77
"""
88

9-
Base.@kwdef struct DatasetStorage
9+
Base.@kwdef struct _DatasetStorage
1010
credentials_url::String
1111
region::String
1212
bucket::String
@@ -50,7 +50,7 @@ Base.@kwdef struct Dataset
5050
_downloadURL::String
5151
_version::Union{Nothing, String}
5252
_versions::Vector
53-
_storage::DatasetStorage
53+
_storage::_DatasetStorage
5454
# Should not be used in code, but stores the full server
5555
# response for developer convenience.
5656
_config::Dict
@@ -74,7 +74,7 @@ function Dataset(d::Dict)
7474
_utc2localtz(datetime_utc)
7575
end,
7676
_version=isnothing(d["version"]) ? nothing : d["version"],
77-
_storage=DatasetStorage(;
77+
_storage=_DatasetStorage(;
7878
credentials_url=d["credentials_url"],
7979
region=d["storage"]["bucket_region"],
8080
bucket=d["storage"]["bucket"],

test/runtests.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ end
8080
:AbstractJobConfig, :AbstractJuliaHubApp,
8181
:appbundle, :AppBundleSizeError, :ApplicationJob, :Authentication,
8282
:AuthenticationError, :BatchJob, :BatchImage, :ComputeConfig, :Dataset,
83-
:DatasetReference, :DatasetStorage,
83+
:DatasetReference,
8484
:DefaultApp, :FileHash, :InvalidAuthentication, :InvalidRequestError, :Job,
8585
:WorkloadConfig, :JobFile, :JobLogMessage, :JobReference, :JobStatus,
8686
:JuliaHub, :JuliaHubConnectionError, :JuliaHubError,

0 commit comments

Comments
 (0)