clean up, tests, version

Author: mortenpi

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Version [v0.1.15] - 2025-08-28
+
+### Fixed
+
+* The `JuliaHub.upload_dataset` now correctly throws a `JuliaHubError` on certain backend errors. ([#103])
+
 ## Version [v0.1.14] - 2025-06-11
 
 ### Added

Project.toml

@@ -1,7 +1,7 @@
 name = "JuliaHub"
 uuid = "bc7fa6ce-b75e-4d60-89ad-56c957190b6e"
 authors = ["JuliaHub Inc."]
-version = "0.1.14"
+version = "0.1.15"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

src/datasets.jl

@@ -695,7 +695,6 @@ function upload_dataset end
         # Any other 404 or other non-200 response indicates a backend failure
         _throw_invalidresponse(r)
     end
-    _check_internal_error(r; var="POST /user/datasets/{name}/versions")
     upload_config = _check_dataset_upload_config(r, dtype; newly_created_dataset)
     # Upload the actual data
     try
@@ -794,7 +793,9 @@ function _new_dataset(
 end
 
 function _open_dataset_version(auth::Authentication, name::AbstractString)::_RESTResponse
-    _restcall(auth, :POST, "user", "datasets", name, "versions")
+    r = _restcall(auth, :POST, "user", "datasets", name, "versions")
+    _check_internal_error(r; var="POST /user/datasets/{name}/versions")
+    return r
 end
 
 function _upload_dataset(upload_config, local_path; progress::Bool)

src/projects.jl

@@ -241,7 +241,6 @@ function upload_project_dataset(
         # Other response codes indicate a backend failure
         _throw_invalidresponse(r)
     end
-    _check_internal_error(r; var="POST /user/datasets/{name}/versions")
     # ...
     upload_config = _check_dataset_upload_config(r, dtype; newly_created_dataset=false)
     # Upload the actual data
@@ -283,12 +282,14 @@ function _open_dataset_version(
     auth::Authentication, dataset_uuid::UUID, project_uuid::UUID
 )::_RESTResponse
     body = Dict("project" => string(project_uuid))
-    return JuliaHub._restcall(
+    r = JuliaHub._restcall(
         auth,
         :POST,
         ("datasets", string(dataset_uuid), "versions"),
         JSON.json(body),
     )
+    _check_internal_error(r; var="POST /user/datasets/{name}/versions")
+    return r
 end
 
 function _close_dataset_version(

test/datasets.jl

@@ -435,6 +435,13 @@ end
         @test_throws TypeError JuliaHub.upload_dataset(
             "example-dataset-license", @__FILE__; replace=true, license=(:fulltext, 1234)
         )
+
+        # Make sure we throw a JuliaHubError when we encounter an internal backend error
+        # that gets reported over a 200.
+        @test JuliaHub.upload_dataset("example-dataset-200-error-1", @__FILE__) isa JuliaHub.Dataset
+        MOCK_JULIAHUB_STATE[:internal_error_200] = true
+        @test_throws JuliaHub.JuliaHubError JuliaHub.upload_dataset("example-dataset-200-error", @__FILE__)
+        MOCK_JULIAHUB_STATE[:internal_error_200] = false
     end
     empty!(MOCK_JULIAHUB_STATE)
 end

test/mocking.jl

@@ -46,6 +46,14 @@ JuliaHub.__AUTH__[] = DEFAULT_GLOBAL_MOCK_AUTH
 Mocking.activate()
 const MOCK_JULIAHUB_STATE = Dict{Symbol, Any}()
 jsonresponse(status) = d -> JuliaHub._RESTResponse(status, JSON.json(d))
+function internal_error_200_response()
+    d = Dict(
+        "success" => false,
+        "internal_error" => true,
+        "message" => "Internal Server Error",
+    )
+    return JuliaHub._RESTResponse(200, JSON.json(d))
+end
 mocking_patch = [
     Mocking.@patch(
         JuliaHub._rest_request_mockable(args...; kwargs...) = _restcall_mocked(args...; kwargs...)
@@ -412,6 +420,9 @@ function _restcall_mocked(method, url, headers, payload; query)
             Dict("repo_id" => string(UUIDs.uuid4())) |> jsonresponse(200)
         end
     elseif (method == :POST) && endswith(url, DATASET_VERSIONS_REGEX)
+        if get(MOCK_JULIAHUB_STATE, :internal_error_200, false)
+            return internal_error_200_response()
+        end
         dataset, is_user = let m = match(DATASET_VERSIONS_REGEX, url)
             URIs.unescapeuri(m[2]), m[1] == "user/"
         end

test/projects.jl

@@ -243,6 +243,10 @@ end
         @test dataset.project.uuid === project_auth_2.project_id
         @test dataset.project.is_writable === false
         @test JuliaHub.upload_project_dataset(dataset_noproject, @__FILE__) isa JuliaHub.Dataset
+
+        MOCK_JULIAHUB_STATE[:internal_error_200] = true
+        @test_throws JuliaHub.JuliaHubError JuliaHub.upload_project_dataset(dataset_noproject, @__FILE__)
+        MOCK_JULIAHUB_STATE[:internal_error_200] = false
     end
 end