fix: correctly allow for license=(:fulltext, ...) in update_dataset
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
requested changes
Dec 4, 2024
Co-authored-by: Sebastian Pfitzner <[email protected]>
pfitzseb
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_datasetfunction (and by extension,upload_dataset) should, according to the documentation, acceptlicense = (:fulltext, ...)when you want to set a custom license. However, this was currently implemented as(:text, ...), and:fulltextwould throw an error.This PR fixes the implementation to correctly follow the docs and accept
license = (:fulltext, ...). We also keep supportinglicense = (:text, ...)as a deprecated argument as well, since this doesn't cost us much. It also adds test coverage for thelicenseargument.