Skip to content

Conversation

@mortenpi
Copy link
Member

With probably 1.11, we started getting a

JET: JET-test failed at /home/runner/.julia/packages/JET/zHVn3/src/JET.jl:107[8](https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/11589518895/job/32265190402?pr=74#step:6:9)
  Expression: (JET.report_package)("JuliaHub"; toplevel_logger = nothing, report_config = JuliaHubReportFilter())
  ═════ 1 possible error found ═════
  ┌ submit_job(app::JuliaHub.AbstractJobConfig; ncpu::Integer, ngpu::Integer, memory::Integer, nnodes::Union{…}, elastic::Bool, process_per_node::Bool, auth::JuliaHub.Authentication, kwargs...) @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:1186
  │┌  @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:118[9](https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/11589518895/job/32265190402?pr=74#step:6:10)
  ││┌ submit_job(app::JuliaHub.AbstractJobConfig, compute::JuliaHub.ComputeConfig; name::Union{…}, alias::Union{…}, env::Any, project::Union{…}, timelimit::Union{…}, expose::Union{…}, _image_sha256::Union{…}, kwargs...) @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:1216
  │││┌ submit_job(c::JuliaHub.WorkloadConfig) @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:[12](https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/11589518895/job/32265190402?pr=74#step:6:13)22
  ││││┌  @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:1249
  │││││ no matching method found `convert(::Type{Dict}, ::NamedTuple)`: convert(JuliaHub.Dict, _26::NamedTuple)
  ││││└────────────────────

from JET. Unsure exactly why, but in this case, the type assertion also sort of functions as documentation -- the .args field from the app name tuple should always be a Dict. So it seems file to work around the issue like this.

@mortenpi mortenpi requested a review from a team October 31, 2024 04:40
@mortenpi mortenpi merged commit 0d142ec into main Dec 4, 2024
13 checks passed
@mortenpi mortenpi deleted the mp/fix-jet branch December 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants