Skip to content

Conversation

@krynju
Copy link
Member

@krynju krynju commented May 8, 2025

Image options are being extended by tag and sha.
Previously an image option would be an image key and a type.

Now optionally an image_tag or image_sha field can appear in the image option and they should be used in job submission if chosen.
The other bigger change is that the unique constraint on options is no longer just the key, but now it's a unique constraint on key, tag and sha. This means the same key can appear multiple times with different tag/sha combinations.

This should be nonbreaking in any direction. Older client ignores the tag/sha and will just list another option with the same key. Older instances will never send tag/sha so using a newer client there is ok too.

@krynju krynju force-pushed the kr/taginoptions branch from 6a4c2c8 to 307df58 Compare May 8, 2025 12:40
@krynju krynju force-pushed the kr/taginoptions branch from 307df58 to 29b83fa Compare May 8, 2025 14:32
@krynju krynju marked this pull request as ready for review May 13, 2025 07:44
@krynju krynju marked this pull request as draft May 14, 2025 08:38
@krynju krynju marked this pull request as ready for review May 20, 2025 16:41
@krynju krynju requested a review from mortenpi May 30, 2025 09:45
mortenpi
mortenpi previously approved these changes Jun 11, 2025
@mortenpi mortenpi enabled auto-merge (squash) June 11, 2025 12:03
@mortenpi mortenpi mentioned this pull request Jun 11, 2025
@mortenpi mortenpi merged commit 5a1e635 into main Jun 11, 2025
19 of 22 checks passed
@mortenpi mortenpi deleted the kr/taginoptions branch June 11, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants